Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1451223004: GN: Add depfile for java_cpp_enum (Closed)

Created:
5 years, 1 month ago by agrieve
Modified:
5 years, 1 month ago
Reviewers:
pkotwicz
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Add depfile for java_cpp_enum BUG=558194 Committed: https://crrev.com/7a07b2248c71a8497fca790f511d461c249bc3e0 Cr-Commit-Position: refs/heads/master@{#360527}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M build/android/gyp/java_cpp_enum.py View 3 chunks +19 lines, -7 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +7 lines, -1 line 2 comments Download

Messages

Total messages: 13 (5 generated)
agrieve
On 2015/11/17 02:57:46, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:pkotwicz@chromium.org bump
5 years, 1 month ago (2015-11-18 20:30:57 UTC) #3
pkotwicz
LGTM, but please add a bug number to the CL The reason you are making ...
5 years, 1 month ago (2015-11-18 23:09:45 UTC) #5
pkotwicz
https://codereview.chromium.org/1451223004/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1451223004/diff/1/build/config/android/rules.gni#newcode351 build/config/android/rules.gni:351: depfile = "$target_gen_dir/$target_name.d" Nit: Shouldn't |depfile| be |_depfile| ?
5 years, 1 month ago (2015-11-18 23:16:24 UTC) #6
pkotwicz
https://codereview.chromium.org/1451223004/diff/1/build/config/android/rules.gni File build/config/android/rules.gni (right): https://codereview.chromium.org/1451223004/diff/1/build/config/android/rules.gni#newcode351 build/config/android/rules.gni:351: depfile = "$target_gen_dir/$target_name.d" Never mind, depfile is a parameter ...
5 years, 1 month ago (2015-11-18 23:17:50 UTC) #7
agrieve
On 2015/11/18 23:09:45, pkotwicz wrote: > LGTM, but please add a bug number to the ...
5 years, 1 month ago (2015-11-19 03:46:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1451223004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1451223004/1
5 years, 1 month ago (2015-11-19 03:46:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 05:30:13 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 05:31:42 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7a07b2248c71a8497fca790f511d461c249bc3e0
Cr-Commit-Position: refs/heads/master@{#360527}

Powered by Google App Engine
This is Rietveld 408576698