Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: build/config/android/rules.gni

Issue 1451223004: GN: Add depfile for java_cpp_enum (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/gyp/java_cpp_enum.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 090f55700ca812a3d4c02daf497d0d76a60a739d..7e242f5ea13a2d1f14f373b52b633a63295f98c5 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -348,13 +348,19 @@ template("java_cpp_enum") {
])
script = "//build/android/gyp/java_cpp_enum.py"
+ depfile = "$target_gen_dir/$target_name.d"
pkotwicz 2015/11/18 23:16:24 Nit: Shouldn't |depfile| be |_depfile| ?
pkotwicz 2015/11/18 23:17:50 Never mind, depfile is a parameter of action
_srcjar_path = "${target_gen_dir}/${target_name}.srcjar"
_rebased_srcjar_path = rebase_path(_srcjar_path, root_build_dir)
_rebased_sources = rebase_path(invoker.sources, root_build_dir)
- args = [ "--srcjar=$_rebased_srcjar_path" ] + _rebased_sources
+ args = [
+ "--depfile",
+ rebase_path(depfile, root_build_dir),
+ "--srcjar=$_rebased_srcjar_path",
+ ] + _rebased_sources
outputs = [
+ depfile,
_srcjar_path,
]
}
« no previous file with comments | « build/android/gyp/java_cpp_enum.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698