Remove unnecessary repaint from line layout and cleanup logic

Remove unnecessary repaint from line layout and cleanup logic

In the beforetime, it apparently made sense to use the cached repaint
rect from RenderLayer directly within line layout code to ensure we
got repainted. We now properly repaint ourself in this case without
having to rely on reaching directly into our layer for the info.

While I'm in the code, I'm moving the logic to mark ourself as
needing layout to ensure we trigger a repaint of ourself to
determineStartPosition (since it's responsible for marking the block
for full layout to begin with), and moving the hasInlineChild
optimization to LineLayoutState.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165800

[eae, 2014-01-24 18:57:38]

LGTM

[commit-bot: I haz the power, 2014-01-24 18:58:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leviw@chromium.org/145083009/1

[commit-bot: I haz the power, 2014-01-24 21:55:30]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2014-01-24 21:59:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leviw@chromium.org/145083009/1

[commit-bot: I haz the power, 2014-01-25 00:19:26]

Change committed as 165800

[ojan, 2014-01-28 20:55:23]

https://codereview.chromium.org/145083009/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/145083009/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlockLineLayout.cpp:1680:
setNeedsLayout(MarkOnlyThis);
Why do this instead of calling repaint directly? Doesn't forcing a layout cause
use to do a bunch of extra layout work?

[leviw_travelin_and_unemployed, 2014-01-28 21:42:31]

https://codereview.chromium.org/145083009/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBlockLineLayout.cpp (right):

https://codereview.chromium.org/145083009/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBlockLineLayout.cpp:1680:
setNeedsLayout(MarkOnlyThis);
On 2014/01/28 20:55:23, ojan wrote:
> Why do this instead of calling repaint directly? Doesn't forcing a layout
cause
> use to do a bunch of extra layout work?

Perhaps this can be further optimized, but this isn't a change from the previous
codepath. The previous comment suggests this is necessary for regions.