Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1450453002: GN: Refactor PNaCl toolchain definitions to use a template (Closed)

Created:
5 years, 1 month ago by Roland McGrath
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, Petr Hosek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Refactor PNaCl toolchain definitions to use a template This reduces duplicated code by using a template. Ironically, some extra duplication is necessitated by GN bug 555724. The variable definition can be hoisted back up when that bug is fixed. BUG= none R=dpranke@chromium.org, phosek@chromium.org Committed: https://crrev.com/8b3b31d64338c7eadb59b433da6a933f9ad1c0ca Cr-Commit-Position: refs/heads/master@{#359643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -28 lines) Patch
M build/toolchain/nacl/BUILD.gn View 4 chunks +40 lines, -28 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Roland McGrath
5 years, 1 month ago (2015-11-13 20:31:19 UTC) #1
Petr Hosek
lgtm
5 years, 1 month ago (2015-11-13 20:40:55 UTC) #2
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-13 20:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450453002/1
5 years, 1 month ago (2015-11-13 21:05:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-13 21:16:02 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 21:17:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b3b31d64338c7eadb59b433da6a933f9ad1c0ca
Cr-Commit-Position: refs/heads/master@{#359643}

Powered by Google App Engine
This is Rietveld 408576698