Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 145023006: Revert of Add factory class for generating various flavors of GrTextContext. (Closed)

Created:
6 years, 11 months ago by jvanverth1
Modified:
6 years, 11 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Add factory class for generating various flavors of GrTextContext. (https://codereview.chromium.org/144283002/) Reason for revert: Breaks Chrome. Need to fix template issue. Original issue's description: > Add factory class for generating various flavors of GrTextContext. > > This is the first pass of making Gr*TextContext more generic and easily > subclassed. The next stage will be making GrBitmapTextContext and > GrDistanceFieldTextContext more similar by moving the SkDraw loop into > each subclass. > > BUG=skia:2018 > > Committed: http://code.google.com/p/skia/source/detail?r=13142 TBR=bsalomon@google.com,reed@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2018 Committed: http://code.google.com/p/skia/source/detail?r=13143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -122 lines) Patch
M include/gpu/GrBitmapTextContext.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/gpu/GrDistanceFieldTextContext.h View 3 chunks +4 lines, -4 lines 0 comments Download
M include/gpu/GrTextContext.h View 2 chunks +2 lines, -72 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrTextContext.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 7 chunks +13 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jvanverth1
Created Revert of Add factory class for generating various flavors of GrTextContext.
6 years, 11 months ago (2014-01-22 21:53:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/145023006/1
6 years, 11 months ago (2014-01-22 21:53:37 UTC) #2
commit-bot: I haz the power
Presubmit check for 145023006-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 11 months ago (2014-01-22 21:53:49 UTC) #3
jvanverth1
LGTM, anyone?
6 years, 11 months ago (2014-01-22 21:58:39 UTC) #4
bsalomon
On 2014/01/22 21:58:39, JimVV wrote: > LGTM, anyone? lgtm
6 years, 11 months ago (2014-01-22 21:59:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/145023006/1
6 years, 11 months ago (2014-01-22 22:01:31 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-22 22:01:46 UTC) #7
Message was sent while issue was closed.
Change committed as 13143

Powered by Google App Engine
This is Rietveld 408576698