Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1450133003: [DevTools] Promote Device Mode v2 to default experiments. (Closed)

Created:
5 years, 1 month ago by dgozman
Modified:
5 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Promote Device Mode v2 to default experiments. - media inspector UI updated; - removed showViewSizeOnResize; - narrow shown-by-default device list; - device select tweaks. BUG=540864 NOTRY=true Committed: https://crrev.com/65aed7623c7a3066bb387b78861922725fcf076d Cr-Commit-Position: refs/heads/master@{#359996}

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -284 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 7 chunks +3 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg View 1 2 chunks +13 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs.png View 1 Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png View 1 Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulated_devices/module.json View 1 32 chunks +49 lines, -165 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 4 chunks +30 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/mediaQueryInspector.css View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 4 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 7 chunks +2 lines, -31 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
dgozman
Take a look please.
5 years, 1 month ago (2015-11-16 22:46:20 UTC) #2
dgozman
PTAL
5 years, 1 month ago (2015-11-17 01:44:23 UTC) #3
pfeldman
lgtm
5 years, 1 month ago (2015-11-17 02:20:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450133003/20001
5 years, 1 month ago (2015-11-17 02:23:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450133003/20001
5 years, 1 month ago (2015-11-17 02:34:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/135906)
5 years, 1 month ago (2015-11-17 02:56:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1450133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1450133003/20001
5 years, 1 month ago (2015-11-17 04:04:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 04:11:48 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 04:12:24 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/65aed7623c7a3066bb387b78861922725fcf076d
Cr-Commit-Position: refs/heads/master@{#359996}

Powered by Google App Engine
This is Rietveld 408576698