third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js - Issue 1450133003: [DevTools] Promote Device Mode v2 to default experiments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js

Issue 1450133003: [DevTools] Promote Device Mode v2 to default experiments. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tweaks Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js b/third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js

index 0b5f589e1306d41285e07fed73893a5a54ebea75..485804c865233e97c49fe54c3d50fd812b30b430 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/OverridesSupport.js

@@ -748,7 +748,6 @@ WebInspector.OverridesSupport.prototype = {

{

var showRulersValue = WebInspector.moduleSetting("showMetricsRulers").get();

for (var target of WebInspector.targetManager.targets(WebInspector.Target.Type.Page)) {

- target.pageAgent().setShowViewportSizeOnResize(!this._pageResizerActive(), showRulersValue);

var domModel = WebInspector.DOMModel.fromTarget(target);

if (domModel)

domModel.setHighlightSettings(showRulersValue && !this._pageResizerActive(), showRulersValue);