Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1450113003: Avoid strerror_r portability issues (Closed)

Created:
5 years, 1 month ago by kulakowski
Modified:
5 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Missed a spot #

Patch Set 3 : Use a common helper #

Patch Set 4 : Fix ugly const cast #

Patch Set 5 : Don't compile for windows #

Total comments: 1

Patch Set 6 : Move impls into os specific headers #

Patch Set 7 : oops namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -51 lines) Patch
M runtime/bin/dbg_connection_macos.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/file_android.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/file_linux.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/bin/file_macos.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/process_android.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/process_linux.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M runtime/bin/process_macos.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/thread_android.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/thread_linux.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/thread_macos.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/utils_android.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/utils_linux.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/bin/utils_macos.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/platform/utils.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/platform/utils_android.h View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/platform/utils_linux.h View 1 2 3 4 5 6 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/platform/utils_macos.h View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/os_thread_android.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/os_thread_linux.cc View 1 2 2 chunks +3 lines, -14 lines 0 comments Download
M runtime/vm/os_thread_macos.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
kulakowski1
Alternatively, https://github.com/dart-lang/sdk/blob/1a038d5030e4b96b8f37e3a6ed858375b6c2c12d/runtime/vm/os_thread_linux.cc#L19 could be used to a more accessible place and used throughout the codebase.
5 years, 1 month ago (2015-11-17 00:45:07 UTC) #2
kulakowski1
On 2015/11/17 00:45:07, kulakowski1 wrote: > Alternatively, > https://github.com/dart-lang/sdk/blob/1a038d5030e4b96b8f37e3a6ed858375b6c2c12d/runtime/vm/os_thread_linux.cc#L19 > could be used to a ...
5 years, 1 month ago (2015-11-17 01:40:54 UTC) #3
Cutch
On 2015/11/17 01:40:54, kulakowski1 wrote: > On 2015/11/17 00:45:07, kulakowski1 wrote: > > Alternatively, > ...
5 years, 1 month ago (2015-11-17 15:34:39 UTC) #4
kulakowski1
ptaal
5 years, 1 month ago (2015-11-17 18:54:23 UTC) #5
Cutch
lgtm
5 years, 1 month ago (2015-11-17 19:02:59 UTC) #6
kulakowski1
On 2015/11/17 19:02:59, Cutch wrote: > lgtm Cool. I don't think I have commit access, ...
5 years, 1 month ago (2015-11-17 19:12:56 UTC) #7
Cutch
Committed patchset #4 (id:60001) manually as ca81c1732b26cec58d9a16e19fd7fc925dcf3bbf.
5 years, 1 month ago (2015-11-17 23:23:51 UTC) #8
Cutch
On 2015/11/17 23:23:51, Cutch wrote: > Committed patchset #4 (id:60001) manually as > ca81c1732b26cec58d9a16e19fd7fc925dcf3bbf. I ...
5 years, 1 month ago (2015-11-18 00:33:26 UTC) #9
kulakowski1
Ah, sorry. This should do it, I think.
5 years, 1 month ago (2015-11-18 01:28:48 UTC) #10
Ivan Posva
DBC -ip https://codereview.chromium.org/1450113003/diff/80001/runtime/platform/utils.h File runtime/platform/utils.h (right): https://codereview.chromium.org/1450113003/diff/80001/runtime/platform/utils.h#newcode218 runtime/platform/utils.h:218: #if !defined(TARGET_OS_WINDOWS) A better way to solve ...
5 years, 1 month ago (2015-11-18 05:00:49 UTC) #12
kulakowski1
On 2015/11/18 05:00:49, Ivan Posva wrote: > DBC -ip > > https://codereview.chromium.org/1450113003/diff/80001/runtime/platform/utils.h > File runtime/platform/utils.h ...
5 years, 1 month ago (2015-11-18 16:54:52 UTC) #13
kulakowski
On 2015/11/18 16:54:52, kulakowski1 wrote: > On 2015/11/18 05:00:49, Ivan Posva wrote: > > DBC ...
5 years, 1 month ago (2015-11-19 21:47:01 UTC) #14
Cutch
5 years, 1 month ago (2015-11-19 22:19:23 UTC) #15
Message was sent while issue was closed. 
On 2015/11/19 21:47:01, kulakowski wrote:
> On 2015/11/18 16:54:52, kulakowski1 wrote:
> > On 2015/11/18 05:00:49, Ivan Posva wrote:
> > > DBC -ip
> > > 
> > >
> https://codereview.chromium.org/1450113003/diff/80001/runtime/platform/utils.h
> > > File runtime/platform/utils.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1450113003/diff/80001/runtime/platform/utils....
> > > runtime/platform/utils.h:218: #if !defined(TARGET_OS_WINDOWS)
> > > A better way to solve this would be to move the implementation into the
> > platform
> > > specific utils_xyz.cc file.
> > 
> > Done.
> 
> John: PTAL

Landed here: https://codereview.chromium.org/1466523002/

Powered by Google App Engine
This is Rietveld 408576698