Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: runtime/bin/dbg_connection_macos.cc

Issue 1450113003: Avoid strerror_r portability issues (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: oops namespace Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/eventhandler_macos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dbg_connection_macos.cc
diff --git a/runtime/bin/dbg_connection_macos.cc b/runtime/bin/dbg_connection_macos.cc
index 4da21cd99feecd7ea0c8d79ce119f2b56c230b3d..dd944e091a444cfb8337fd5602c457d6f9925e0b 100644
--- a/runtime/bin/dbg_connection_macos.cc
+++ b/runtime/bin/dbg_connection_macos.cc
@@ -90,7 +90,7 @@ void DebuggerConnectionImpl::HandleEvent(struct kevent* event) {
if (status == -1) {
const int kBufferSize = 1024;
char error_message[kBufferSize];
- strerror_r(errno, error_message, kBufferSize);
+ Utils::StrError(errno, error_message, kBufferSize);
FATAL1("Failed adding debugger socket to kqueue: %s\n", error_message);
}
*/
@@ -117,7 +117,7 @@ void DebuggerConnectionImpl::Handler(uword args) {
if (result == -1) {
const int kBufferSize = 1024;
char error_message[kBufferSize];
- strerror_r(errno, error_message, kBufferSize);
+ Utils::StrError(errno, error_message, kBufferSize);
FATAL1("kevent failed %s\n", error_message);
} else {
ASSERT(result <= kMaxEvents);
@@ -149,7 +149,7 @@ void DebuggerConnectionImpl::SetupPollQueue() {
if (status == -1) {
const int kBufferSize = 1024;
char error_message[kBufferSize];
- strerror_r(errno, error_message, kBufferSize);
+ Utils::StrError(errno, error_message, kBufferSize);
FATAL1("Failed adding wakeup pipe fd to kqueue: %s\n", error_message);
}
@@ -160,7 +160,7 @@ void DebuggerConnectionImpl::SetupPollQueue() {
if (status == -1) {
const int kBufferSize = 1024;
char error_message[kBufferSize];
- strerror_r(errno, error_message, kBufferSize);
+ Utils::StrError(errno, error_message, kBufferSize);
FATAL1("Failed adding listener socket to kqueue: %s\n", error_message);
}
}
« no previous file with comments | « no previous file | runtime/bin/eventhandler_macos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698