Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 1449963002: Oilpan: move WorkerInspectorController's frontend channel to the heap. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: move WorkerInspectorController's frontend channel to the heap. Move along this WorkerInspectorController-owned object to the heap also, allowing it to keep a traced reference to its worker global scope. R=haraken BUG=553613 Committed: https://crrev.com/4df48d7e3db11cfbb00518128cb54d3f329cc54e Cr-Commit-Position: refs/heads/master@{#360052}

Patch Set 1 #

Patch Set 2 : fix MSVC visibility quibbles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -25 lines) Patch
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 6 chunks +44 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-16 18:31:23 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-16 23:33:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449963002/1
5 years, 1 month ago (2015-11-17 06:17:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/67636)
5 years, 1 month ago (2015-11-17 06:50:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449963002/20001
5 years, 1 month ago (2015-11-17 09:43:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 10:58:39 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 10:59:32 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4df48d7e3db11cfbb00518128cb54d3f329cc54e
Cr-Commit-Position: refs/heads/master@{#360052}

Powered by Google App Engine
This is Rietveld 408576698