Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerInspectorController.h

Issue 1449963002: Oilpan: move WorkerInspectorController's frontend channel to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix MSVC visibility quibbles Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
diff --git a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
index fe6e30dc649972e94169125c2b765fdb4df13598..1bba3adb92926342b1549f6cbfef2a746bffb3e9 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
+++ b/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
@@ -53,7 +53,7 @@ class WorkerGlobalScope;
class WorkerRuntimeAgent;
class WorkerThreadDebugger;
-class WorkerInspectorController : public RefCountedWillBeGarbageCollectedFinalized<WorkerInspectorController>, public InspectorRuntimeAgent::Client {
+class WorkerInspectorController final : public RefCountedWillBeGarbageCollectedFinalized<WorkerInspectorController>, public InspectorRuntimeAgent::Client {
WTF_MAKE_NONCOPYABLE(WorkerInspectorController);
USING_FAST_MALLOC_WILL_BE_REMOVED(WorkerInspectorController);
public:
@@ -79,6 +79,11 @@ private:
void resumeStartup() override;
bool isRunRequired() override;
+ class PageInspectorProxy;
+ friend WTF::OwnedPtrDeleter<PageInspectorProxy>;
+
+ InspectorFrontendChannel* frontendChannel() const;
+
RawPtrWillBeMember<WorkerGlobalScope> m_workerGlobalScope;
OwnPtr<InspectorStateClient> m_stateClient;
OwnPtrWillBeMember<InspectorCompositeState> m_state;
@@ -86,7 +91,7 @@ private:
OwnPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
OwnPtr<WorkerThreadDebugger> m_workerThreadDebugger;
InspectorAgentRegistry m_agents;
- OwnPtr<InspectorFrontendChannel> m_frontendChannel;
+ OwnPtrWillBeMember<PageInspectorProxy> m_pageInspectorProxy;
OwnPtr<InspectorFrontend> m_frontend;
RefPtrWillBeMember<InspectorBackendDispatcher> m_backendDispatcher;
RawPtrWillBeMember<WorkerDebuggerAgent> m_workerDebuggerAgent;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698