Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1449853002: depot_tools: make CheckLicense warn instead of notify (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
pgervais
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: make CheckLicense warn instead of notify BUG=553681 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M presubmit_canned_checks.py View 1 chunk +1 line, -5 lines 0 comments Download
M tests/presubmit_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-16 11:24:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449853002/1
5 years, 1 month ago (2015-11-16 11:25:05 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 11:26:45 UTC) #6
pgervais
On 2015/11/16 11:26:45, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 1 month ago (2015-11-16 12:44:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449853002/1
5 years, 1 month ago (2015-11-16 12:46:10 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 12:47:54 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297563

Powered by Google App Engine
This is Rietveld 408576698