tests/presubmit_unittest.py - Issue 1449853002: depot_tools: make CheckLicense warn instead of notify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/presubmit_unittest.py

Issue 1449853002: depot_tools: make CheckLicense warn instead of notify (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/presubmit_unittest.py

diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py

index 2a90ab3c340d7dada9b6f5fd7590f9adc2787803..6456e0e6c5a563e30dac1d791825c30d1f3401b3 100755

--- a/tests/presubmit_unittest.py

+++ b/tests/presubmit_unittest.py

@@ -2324,7 +2324,7 @@ class CannedChecksUnittest(PresubmitTestsBase):

)

self._LicenseCheck(text, license_text, False,

- presubmit.OutputApi.PresubmitNotifyResult)

+ presubmit.OutputApi.PresubmitPromptWarning)

def testCheckLicenseEmptySuccess(self):

text = ''

« no previous file with comments | « presubmit_canned_checks.py ('k') | no next file » | no next file with comments »