Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1449423002: Revert of Prepare to enable in-object properties in subclasses on a case by case basis. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@bytecode-array-sizeof-fix
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Prepare to enable in-object properties in subclasses on a case by case basis. (patchset #3 id:100001 of https://codereview.chromium.org/1448313002/ ) Reason for revert: Breaks GC stress: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/3174/steps/Mjsunit/logs/classes-subclass-buil.. Original issue's description: > Prepare to enable in-object properties in subclasses on a case by case basis. > > Minor cleanup in VisitorId selection. > > Committed: https://crrev.com/7c449a62edfc03aed84d94da323dcfe2b51a3600 > Cr-Commit-Position: refs/heads/master@{#32030} TBR=verwaest@chromium.org,mstarzinger@chromium.org,ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a2a2ebe60600d69f976fb278145aa131b9d84710 Cr-Commit-Position: refs/heads/master@{#32041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -96 lines) Patch
M src/heap/objects-visiting.cc View 3 chunks +19 lines, -7 lines 0 comments Download
M src/objects.cc View 2 chunks +18 lines, -89 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
Created Revert of Prepare to enable in-object properties in subclasses on a case by case ...
5 years, 1 month ago (2015-11-17 13:17:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1449423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1449423002/1
5 years, 1 month ago (2015-11-17 13:17:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 13:17:26 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 13:17:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2a2ebe60600d69f976fb278145aa131b9d84710
Cr-Commit-Position: refs/heads/master@{#32041}

Powered by Google App Engine
This is Rietveld 408576698