Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: src/heap/objects-visiting.cc

Issue 1449423002: Revert of Prepare to enable in-object properties in subclasses on a case by case basis. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@bytecode-array-sizeof-fix
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/objects-visiting.h" 5 #include "src/heap/objects-visiting.h"
6 6
7 #include "src/heap/mark-compact-inl.h" 7 #include "src/heap/mark-compact-inl.h"
8 #include "src/heap/objects-visiting-inl.h" 8 #include "src/heap/objects-visiting-inl.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 72
73 case CELL_TYPE: 73 case CELL_TYPE:
74 return kVisitCell; 74 return kVisitCell;
75 75
76 case PROPERTY_CELL_TYPE: 76 case PROPERTY_CELL_TYPE:
77 return kVisitPropertyCell; 77 return kVisitPropertyCell;
78 78
79 case WEAK_CELL_TYPE: 79 case WEAK_CELL_TYPE:
80 return kVisitWeakCell; 80 return kVisitWeakCell;
81 81
82 case JS_SET_TYPE:
83 return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
84 JSSet::kSize, has_unboxed_fields);
85
86 case JS_MAP_TYPE:
87 return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
88 JSMap::kSize, has_unboxed_fields);
89
82 case JS_WEAK_MAP_TYPE: 90 case JS_WEAK_MAP_TYPE:
83 case JS_WEAK_SET_TYPE: 91 case JS_WEAK_SET_TYPE:
84 return kVisitJSWeakCollection; 92 return kVisitJSWeakCollection;
85 93
86 case JS_REGEXP_TYPE: 94 case JS_REGEXP_TYPE:
87 return kVisitJSRegExp; 95 return kVisitJSRegExp;
88 96
89 case SHARED_FUNCTION_INFO_TYPE: 97 case SHARED_FUNCTION_INFO_TYPE:
90 return kVisitSharedFunctionInfo; 98 return kVisitSharedFunctionInfo;
91 99
92 case JS_SET_TYPE:
93 case JS_MAP_TYPE:
94 case JS_PROXY_TYPE: 100 case JS_PROXY_TYPE:
101 return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
102 JSProxy::kSize, has_unboxed_fields);
103
95 case JS_FUNCTION_PROXY_TYPE: 104 case JS_FUNCTION_PROXY_TYPE:
96 return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric, 105 return GetVisitorIdForSize(kVisitStruct, kVisitStructGeneric,
97 instance_size, has_unboxed_fields); 106 JSFunctionProxy::kSize, has_unboxed_fields);
107
108 case FOREIGN_TYPE:
109 return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric,
110 Foreign::kSize, has_unboxed_fields);
98 111
99 case SYMBOL_TYPE: 112 case SYMBOL_TYPE:
100 return kVisitSymbol; 113 return kVisitSymbol;
101 114
115 case FILLER_TYPE:
116 return kVisitDataObjectGeneric;
117
102 case JS_ARRAY_BUFFER_TYPE: 118 case JS_ARRAY_BUFFER_TYPE:
103 return kVisitJSArrayBuffer; 119 return kVisitJSArrayBuffer;
104 120
105 case JS_TYPED_ARRAY_TYPE: 121 case JS_TYPED_ARRAY_TYPE:
106 return kVisitJSTypedArray; 122 return kVisitJSTypedArray;
107 123
108 case JS_DATA_VIEW_TYPE: 124 case JS_DATA_VIEW_TYPE:
109 return kVisitJSDataView; 125 return kVisitJSDataView;
110 126
111 case JS_OBJECT_TYPE: 127 case JS_OBJECT_TYPE:
112 case JS_CONTEXT_EXTENSION_OBJECT_TYPE: 128 case JS_CONTEXT_EXTENSION_OBJECT_TYPE:
113 case JS_GENERATOR_OBJECT_TYPE: 129 case JS_GENERATOR_OBJECT_TYPE:
114 case JS_MODULE_TYPE: 130 case JS_MODULE_TYPE:
115 case JS_VALUE_TYPE: 131 case JS_VALUE_TYPE:
116 case JS_DATE_TYPE: 132 case JS_DATE_TYPE:
117 case JS_ARRAY_TYPE: 133 case JS_ARRAY_TYPE:
118 case JS_GLOBAL_PROXY_TYPE: 134 case JS_GLOBAL_PROXY_TYPE:
119 case JS_GLOBAL_OBJECT_TYPE: 135 case JS_GLOBAL_OBJECT_TYPE:
120 case JS_MESSAGE_OBJECT_TYPE: 136 case JS_MESSAGE_OBJECT_TYPE:
121 case JS_SET_ITERATOR_TYPE: 137 case JS_SET_ITERATOR_TYPE:
122 case JS_MAP_ITERATOR_TYPE: 138 case JS_MAP_ITERATOR_TYPE:
123 case JS_ITERATOR_RESULT_TYPE: 139 case JS_ITERATOR_RESULT_TYPE:
124 return GetVisitorIdForSize(kVisitJSObject, kVisitJSObjectGeneric, 140 return GetVisitorIdForSize(kVisitJSObject, kVisitJSObjectGeneric,
125 instance_size, has_unboxed_fields); 141 instance_size, has_unboxed_fields);
126 142
127 case JS_FUNCTION_TYPE: 143 case JS_FUNCTION_TYPE:
128 return kVisitJSFunction; 144 return kVisitJSFunction;
129 145
130 case FILLER_TYPE:
131 if (instance_size == kPointerSize) return kVisitDataObjectGeneric;
132 // Fall through.
133 case FOREIGN_TYPE:
134 case HEAP_NUMBER_TYPE: 146 case HEAP_NUMBER_TYPE:
135 case MUTABLE_HEAP_NUMBER_TYPE: 147 case MUTABLE_HEAP_NUMBER_TYPE:
136 case SIMD128_VALUE_TYPE: 148 case SIMD128_VALUE_TYPE:
137 return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric, 149 return GetVisitorIdForSize(kVisitDataObject, kVisitDataObjectGeneric,
138 instance_size, has_unboxed_fields); 150 instance_size, has_unboxed_fields);
139 151
140 case FIXED_UINT8_ARRAY_TYPE: 152 case FIXED_UINT8_ARRAY_TYPE:
141 case FIXED_INT8_ARRAY_TYPE: 153 case FIXED_INT8_ARRAY_TYPE:
142 case FIXED_UINT16_ARRAY_TYPE: 154 case FIXED_UINT16_ARRAY_TYPE:
143 case FIXED_INT16_ARRAY_TYPE: 155 case FIXED_INT16_ARRAY_TYPE:
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
345 }; 357 };
346 358
347 359
348 template Object* VisitWeakList<Context>(Heap* heap, Object* list, 360 template Object* VisitWeakList<Context>(Heap* heap, Object* list,
349 WeakObjectRetainer* retainer); 361 WeakObjectRetainer* retainer);
350 362
351 template Object* VisitWeakList<AllocationSite>(Heap* heap, Object* list, 363 template Object* VisitWeakList<AllocationSite>(Heap* heap, Object* list,
352 WeakObjectRetainer* retainer); 364 WeakObjectRetainer* retainer);
353 } // namespace internal 365 } // namespace internal
354 } // namespace v8 366 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698