Check in generated Dart bindings and add presubmit script

Check in generated Dart bindings and add presubmit script

- Add mojom_list_dart_outputs.py script which outputs the path to the generated bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is needed.
- Fix mojom generate.dart script to better handle case of missing lib/ directory.

---- Example output #1:

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py
Package mojo_services missing mojo_services/lib/mojo/web_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/command_buffer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/native_viewport.mojom.dart
Package mojo_services missing mojo_services/lib/http_server/http_request.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geocoder.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_message.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_response_disk_cache.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surface_id.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/service_registry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/layouts.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_trees.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_event_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/sharing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/display.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_server_socket.mojom.dart
Package mojo_services missing mojo_services/lib/keyboard/keyboard.mojom.dart
Package mojo_services missing mojo_services/lib/input/input.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surfaces.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/host_resolver.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/navigation.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager_internal.mojom.dart
Package mojo_services missing mojo_services/lib/http_server/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/contacts/contacts.mojom.dart
Package mojo_services missing mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_connection.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/udp_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_events.mojom.dart
Package mojo_services missing mojo_services/lib/icu_data/icu_data.mojom.dart
Package mojo_services missing mojo_services/lib/prediction/prediction.mojom.dart
Package mojo_services missing mojo_services/lib/sensors/sensors.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/directory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/types.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader_interceptor.mojom.dart
Package mojo_services missing mojo_services/lib/http_server/http_server_factory.mojom.dart
Package mojo_services missing mojo_services/lib/notifications/notifications.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu_capabilities.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/quads.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/camera.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/files.mojom.dart
Package mojo_services missing mojo_services/lib/http_server/http_response.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/context_provider.mojom.dart
Package mojo_services missing mojo_services/lib/native_support/process.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/terminal/terminal_client.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geometry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/clipboard.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/terminal/terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/device_info.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/cookie_store.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/animations.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/views.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_bound_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_provider.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_key_codes.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_connected_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/content_handler.mojom.dart
Package mojo_services missing mojo_services/lib/nfc/nfc.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/network_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/file.mojom.dart
Package mojo_services missing mojo_services/lib/authentication/authentication.mojom.dart
Package mojo_services missing mojo_services/lib/tracing/tracing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/net_address.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo_services.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/ --output mojo/dart/packages/
Package mojo missing mojo/lib/mojo/url_response.mojom.dart
Package mojo missing mojo/lib/mojo/interface_control_messages.mojom.dart
Package mojo missing mojo/lib/mojo/http_header.mojom.dart
Package mojo missing mojo/lib/mojo/service_provider.mojom.dart
Package mojo missing mojo/lib/mojo/application.mojom.dart
Package mojo missing mojo/lib/mojo/shell.mojom.dart
Package mojo missing mojo/lib/mojo/url_request.mojom.dart
Package mojo missing mojo/lib/mojo/network_error.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/ --output mojo/dart/packages/

--- Example output #2 (after touching application.mojom):

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py
Package mojo has old mojo/lib/mojo/application.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/ --output mojo/dart/packages/

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/ad0bc6d4074c814ec98ae72cff428e5e5393ed3c

[Cutch, 2015-11-16 23:12:41]

Description was changed from

==========
Check in generated Dart bindings and add presubmit script
==========

to

==========
Check in generated Dart bindings and add presubmit script

TODO: Include generated .mojom.dart files.
TODO: Hook into depottools presubmit machinery. 

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.
==========

[Cutch, 2015-11-16 23:12:41]

johnmccutchan@google.com changed reviewers:
+ jamesr@google.com

[Cutch, 2015-11-16 23:14:38]

Sending this out for review with a couple TODOs pending.

[Cutch, 2015-11-16 23:16:01]

Description was changed from

==========
Check in generated Dart bindings and add presubmit script

TODO: Include generated .mojom.dart files.
TODO: Hook into depottools presubmit machinery. 

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.
==========

to

==========
Check in generated Dart bindings and add presubmit script

TODO: Include generated .mojom.dart files.
TODO: Hook into depottools presubmit machinery. 

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.

---- Example output #1:

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo_services missing mojo_services/lib/mojo/web_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/command_buffer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/native_viewport.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_request.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geocoder.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_message.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_response_disk_cache.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surface_id.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/service_registry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/layouts.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_trees.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/input_event_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/sharing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/display.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_server_socket.mojom.dart
Package mojo_services missing mojo_services/lib/keyboard/keyboard.mojom.dart
Package mojo_services missing mojo_services/lib/input/input.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surfaces.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/host_resolver.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/navigation.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/window_manager_internal.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/contacts/contacts.mojom.dart
Package mojo_services missing
mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_connection.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/udp_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_events.mojom.dart
Package mojo_services missing mojo_services/lib/icu_data/icu_data.mojom.dart
Package mojo_services missing mojo_services/lib/prediction/prediction.mojom.dart
Package mojo_services missing mojo_services/lib/sensors/sensors.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/directory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/types.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_loader_interceptor.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server_factory.mojom.dart
Package mojo_services missing
mojo_services/lib/notifications/notifications.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu_capabilities.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/quads.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/camera.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/view_manager_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/files.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_response.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/context_provider.mojom.dart
Package mojo_services missing
mojo_services/lib/native_support/process.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal_client.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geometry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/clipboard.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/device_info.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/cookie_store.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/animations.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/views.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_bound_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_provider.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_key_codes.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_connected_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/content_handler.mojom.dart
Package mojo_services missing mojo_services/lib/nfc/nfc.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/network_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/file.mojom.dart
Package mojo_services missing
mojo_services/lib/authentication/authentication.mojom.dart
Package mojo_services missing mojo_services/lib/tracing/tracing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/net_address.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo_services.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
Package mojo missing mojo/lib/mojo/url_response.mojom.dart
Package mojo missing mojo/lib/mojo/interface_control_messages.mojom.dart
Package mojo missing mojo/lib/mojo/http_header.mojom.dart
Package mojo missing mojo/lib/mojo/service_provider.mojom.dart
Package mojo missing mojo/lib/mojo/application.mojom.dart
Package mojo missing mojo/lib/mojo/shell.mojom.dart
Package mojo missing mojo/lib/mojo/url_request.mojom.dart
Package mojo missing mojo/lib/mojo/network_error.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/

--- Example output #2 (after touching application.mojom):
$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo has old mojo/lib/mojo/application.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
==========

[Cutch, 2015-11-16 23:16:19]

Description was changed from

==========
Check in generated Dart bindings and add presubmit script

TODO: Include generated .mojom.dart files.
TODO: Hook into depottools presubmit machinery. 

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.

---- Example output #1:

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo_services missing mojo_services/lib/mojo/web_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/command_buffer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/native_viewport.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_request.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geocoder.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_message.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_response_disk_cache.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surface_id.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/service_registry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/layouts.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_trees.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/input_event_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/sharing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/display.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_server_socket.mojom.dart
Package mojo_services missing mojo_services/lib/keyboard/keyboard.mojom.dart
Package mojo_services missing mojo_services/lib/input/input.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surfaces.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/host_resolver.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/navigation.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/window_manager_internal.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/contacts/contacts.mojom.dart
Package mojo_services missing
mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_connection.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/udp_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_events.mojom.dart
Package mojo_services missing mojo_services/lib/icu_data/icu_data.mojom.dart
Package mojo_services missing mojo_services/lib/prediction/prediction.mojom.dart
Package mojo_services missing mojo_services/lib/sensors/sensors.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/directory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/types.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_loader_interceptor.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server_factory.mojom.dart
Package mojo_services missing
mojo_services/lib/notifications/notifications.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu_capabilities.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/quads.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/camera.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/view_manager_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/files.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_response.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/context_provider.mojom.dart
Package mojo_services missing
mojo_services/lib/native_support/process.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal_client.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geometry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/clipboard.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/device_info.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/cookie_store.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/animations.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/views.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_bound_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_provider.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_key_codes.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_connected_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/content_handler.mojom.dart
Package mojo_services missing mojo_services/lib/nfc/nfc.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/network_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/file.mojom.dart
Package mojo_services missing
mojo_services/lib/authentication/authentication.mojom.dart
Package mojo_services missing mojo_services/lib/tracing/tracing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/net_address.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo_services.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
Package mojo missing mojo/lib/mojo/url_response.mojom.dart
Package mojo missing mojo/lib/mojo/interface_control_messages.mojom.dart
Package mojo missing mojo/lib/mojo/http_header.mojom.dart
Package mojo missing mojo/lib/mojo/service_provider.mojom.dart
Package mojo missing mojo/lib/mojo/application.mojom.dart
Package mojo missing mojo/lib/mojo/shell.mojom.dart
Package mojo missing mojo/lib/mojo/url_request.mojom.dart
Package mojo missing mojo/lib/mojo/network_error.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/

--- Example output #2 (after touching application.mojom):
$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo has old mojo/lib/mojo/application.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
==========

to

==========
Check in generated Dart bindings and add presubmit script

TODO: Include generated .mojom.dart files.
TODO: Hook into depottools presubmit machinery. 

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.

---- Example output #1:

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo_services missing mojo_services/lib/mojo/web_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/command_buffer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/native_viewport.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_request.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geocoder.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_message.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_response_disk_cache.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surface_id.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/service_registry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/layouts.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_trees.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/input_event_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/sharing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/display.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_server_socket.mojom.dart
Package mojo_services missing mojo_services/lib/keyboard/keyboard.mojom.dart
Package mojo_services missing mojo_services/lib/input/input.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surfaces.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/host_resolver.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/navigation.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/window_manager_internal.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/contacts/contacts.mojom.dart
Package mojo_services missing
mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_connection.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/udp_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_events.mojom.dart
Package mojo_services missing mojo_services/lib/icu_data/icu_data.mojom.dart
Package mojo_services missing mojo_services/lib/prediction/prediction.mojom.dart
Package mojo_services missing mojo_services/lib/sensors/sensors.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/directory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/types.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_loader_interceptor.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server_factory.mojom.dart
Package mojo_services missing
mojo_services/lib/notifications/notifications.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu_capabilities.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/quads.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/camera.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/view_manager_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/files.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_response.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/context_provider.mojom.dart
Package mojo_services missing
mojo_services/lib/native_support/process.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal_client.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geometry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/clipboard.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/device_info.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/cookie_store.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/animations.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/views.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_bound_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_provider.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_key_codes.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_connected_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/content_handler.mojom.dart
Package mojo_services missing mojo_services/lib/nfc/nfc.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/network_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/file.mojom.dart
Package mojo_services missing
mojo_services/lib/authentication/authentication.mojom.dart
Package mojo_services missing mojo_services/lib/tracing/tracing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/net_address.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo_services.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
Package mojo missing mojo/lib/mojo/url_response.mojom.dart
Package mojo missing mojo/lib/mojo/interface_control_messages.mojom.dart
Package mojo missing mojo/lib/mojo/http_header.mojom.dart
Package mojo missing mojo/lib/mojo/service_provider.mojom.dart
Package mojo missing mojo/lib/mojo/application.mojom.dart
Package mojo missing mojo/lib/mojo/shell.mojom.dart
Package mojo missing mojo/lib/mojo/url_request.mojom.dart
Package mojo missing mojo/lib/mojo/network_error.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/

--- Example output #2 (after touching application.mojom):

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo has old mojo/lib/mojo/application.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
==========

[jamesr, 2015-11-17 01:35:07]

jamesr@chromium.org changed reviewers:
+ jamesr@chromium.org
- jamesr@google.com

[jamesr, 2015-11-17 01:35:08]

I think the presubmit gets a good bit simpler when you integrate into the
PRESUBMIT.py machinery.  That will tell you what files are changed in the patch
being checked so you should not need to call out to list directories or 'git
grep'.  Instead if a changed file ends with ".mojom" you can parse that file for
a DartPackage annotation and if a changed file ends with ".mojom.dart" you can
examine the path to the file to figure out what package it must be for.
Otherwise this looks pretty good so far.

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/packages/mojom/li...
File mojo/dart/packages/mojom/lib/src/generate.dart (right):

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/packages/mojom/li...
mojo/dart/packages/mojom/lib/src/generate.dart:131: // that is an import path.
i think you accidentally a word or few. maybe "..and if found assumes that
//mojo/services/ is on the import path" ?

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/packages/mojom/li...
mojo/dart/packages/mojom/lib/src/generate.dart:170: // TODO(zra): Are other
include paths needed?
i think we can nuke this for now

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/tools/presubmit/c...
File mojo/dart/tools/presubmit/check_mojom_dart.py (right):

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/tools/presubmit/c...
mojo/dart/tools/presubmit/check_mojom_dart.py:34: print('*** Dart Generated
Bindings Check Failed:')
this is a good place to use python's """, i.e.

print("""*** Dart Generated ....
blah blah blah
blah blah blah""" % (package))

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/tools/presubmit/c...
mojo/dart/tools/presubmit/check_mojom_dart.py:145: for mojom_dart in expected:
the mix of hacker_style and camelCase is confusing - please stick to one or the
other (i.e. check_failure)

[Cutch, 2015-11-17 18:16:11]

Description was changed from

==========
Check in generated Dart bindings and add presubmit script

TODO: Include generated .mojom.dart files.
TODO: Hook into depottools presubmit machinery. 

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.

---- Example output #1:

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo_services missing mojo_services/lib/mojo/web_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/command_buffer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/native_viewport.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_request.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geocoder.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_message.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_response_disk_cache.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surface_id.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/service_registry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/layouts.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_trees.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/input_event_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/sharing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/display.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_server_socket.mojom.dart
Package mojo_services missing mojo_services/lib/keyboard/keyboard.mojom.dart
Package mojo_services missing mojo_services/lib/input/input.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surfaces.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/host_resolver.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/navigation.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/window_manager_internal.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/contacts/contacts.mojom.dart
Package mojo_services missing
mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_connection.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/udp_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_events.mojom.dart
Package mojo_services missing mojo_services/lib/icu_data/icu_data.mojom.dart
Package mojo_services missing mojo_services/lib/prediction/prediction.mojom.dart
Package mojo_services missing mojo_services/lib/sensors/sensors.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/directory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/types.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_loader_interceptor.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server_factory.mojom.dart
Package mojo_services missing
mojo_services/lib/notifications/notifications.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu_capabilities.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/quads.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/camera.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/view_manager_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/files.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_response.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/context_provider.mojom.dart
Package mojo_services missing
mojo_services/lib/native_support/process.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal_client.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geometry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/clipboard.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/device_info.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/cookie_store.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/animations.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/views.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_bound_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_provider.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_key_codes.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_connected_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/content_handler.mojom.dart
Package mojo_services missing mojo_services/lib/nfc/nfc.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/network_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/file.mojom.dart
Package mojo_services missing
mojo_services/lib/authentication/authentication.mojom.dart
Package mojo_services missing mojo_services/lib/tracing/tracing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/net_address.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo_services.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
Package mojo missing mojo/lib/mojo/url_response.mojom.dart
Package mojo missing mojo/lib/mojo/interface_control_messages.mojom.dart
Package mojo missing mojo/lib/mojo/http_header.mojom.dart
Package mojo missing mojo/lib/mojo/service_provider.mojom.dart
Package mojo missing mojo/lib/mojo/application.mojom.dart
Package mojo missing mojo/lib/mojo/shell.mojom.dart
Package mojo missing mojo/lib/mojo/url_request.mojom.dart
Package mojo missing mojo/lib/mojo/network_error.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/

--- Example output #2 (after touching application.mojom):

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo has old mojo/lib/mojo/application.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
==========

to

==========
Check in generated Dart bindings and add presubmit script

TODO: Include generated .mojom.dart files.

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.

---- Example output #1:

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo_services missing mojo_services/lib/mojo/web_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/command_buffer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/native_viewport.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_request.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geocoder.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_message.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_response_disk_cache.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surface_id.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/service_registry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/layouts.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_trees.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/input_event_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/sharing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/display.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_server_socket.mojom.dart
Package mojo_services missing mojo_services/lib/keyboard/keyboard.mojom.dart
Package mojo_services missing mojo_services/lib/input/input.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surfaces.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/host_resolver.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/navigation.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/window_manager_internal.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/contacts/contacts.mojom.dart
Package mojo_services missing
mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_connection.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/udp_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_events.mojom.dart
Package mojo_services missing mojo_services/lib/icu_data/icu_data.mojom.dart
Package mojo_services missing mojo_services/lib/prediction/prediction.mojom.dart
Package mojo_services missing mojo_services/lib/sensors/sensors.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/directory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/types.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_loader_interceptor.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server_factory.mojom.dart
Package mojo_services missing
mojo_services/lib/notifications/notifications.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu_capabilities.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/quads.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/camera.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/view_manager_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/files.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_response.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/context_provider.mojom.dart
Package mojo_services missing
mojo_services/lib/native_support/process.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal_client.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geometry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/clipboard.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/device_info.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/cookie_store.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/animations.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/views.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_bound_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_provider.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_key_codes.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_connected_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/content_handler.mojom.dart
Package mojo_services missing mojo_services/lib/nfc/nfc.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/network_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/file.mojom.dart
Package mojo_services missing
mojo_services/lib/authentication/authentication.mojom.dart
Package mojo_services missing mojo_services/lib/tracing/tracing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/net_address.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo_services.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
Package mojo missing mojo/lib/mojo/url_response.mojom.dart
Package mojo missing mojo/lib/mojo/interface_control_messages.mojom.dart
Package mojo missing mojo/lib/mojo/http_header.mojom.dart
Package mojo missing mojo/lib/mojo/service_provider.mojom.dart
Package mojo missing mojo/lib/mojo/application.mojom.dart
Package mojo missing mojo/lib/mojo/shell.mojom.dart
Package mojo missing mojo/lib/mojo/url_request.mojom.dart
Package mojo missing mojo/lib/mojo/network_error.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/

--- Example output #2 (after touching application.mojom):

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo has old mojo/lib/mojo/application.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
==========

[Cutch, 2015-11-17 18:17:15]

Added PRESUBMIT.py checks.

PTAL.

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/packages/mojom/li...
File mojo/dart/packages/mojom/lib/src/generate.dart (right):

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/packages/mojom/li...
mojo/dart/packages/mojom/lib/src/generate.dart:131: // that is an import path.
On 2015/11/17 01:35:07, jamesr wrote:
> i think you accidentally a word or few. maybe "..and if found assumes that
> //mojo/services/ is on the import path" ?

Done.

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/packages/mojom/li...
mojo/dart/packages/mojom/lib/src/generate.dart:170: // TODO(zra): Are other
include paths needed?
On 2015/11/17 01:35:07, jamesr wrote:
> i think we can nuke this for now

Done.

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/tools/presubmit/c...
File mojo/dart/tools/presubmit/check_mojom_dart.py (right):

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/tools/presubmit/c...
mojo/dart/tools/presubmit/check_mojom_dart.py:34: print('*** Dart Generated
Bindings Check Failed:')
On 2015/11/17 01:35:07, jamesr wrote:
> this is a good place to use python's """, i.e.
> 
> print("""*** Dart Generated ....
> blah blah blah
> blah blah blah""" % (package))

Done.

https://codereview.chromium.org/1449203002/diff/1/mojo/dart/tools/presubmit/c...
mojo/dart/tools/presubmit/check_mojom_dart.py:145: for mojom_dart in expected:
On 2015/11/17 01:35:07, jamesr wrote:
> the mix of hacker_style and camelCase is confusing - please stick to one or
the
> other (i.e. check_failure)

Done. I was switching between Dart and Python yesterday....

[jamesr, 2015-11-17 18:32:26]

lgtm.  ship it!

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
File mojo/dart/tools/presubmit/check_mojom_dart.py (right):

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
mojo/dart/tools/presubmit/check_mojom_dart.py:296: # This list is used to verify
that all updated .mojom.dart files were
"all updated mojom.dart files were ..." where's the rest of the sentence?

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
mojo/dart/tools/presubmit/check_mojom_dart.py:321: sys.exit(2)
i would just return 2 here and propagate that back through main. having only one
sys.exit() makes testing easier

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
mojo/dart/tools/presubmit/check_mojom_dart.py:349: print('OK.')
no need to print OK if things are good, the exit code will tell you

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
mojo/dart/tools/presubmit/check_mojom_dart.py:350: sys.exit(0)
return, line 353 is doing the sys.exit()

[Cutch, 2015-11-17 21:27:14]

Description was changed from

==========
Check in generated Dart bindings and add presubmit script

TODO: Include generated .mojom.dart files.

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.

---- Example output #1:

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo_services missing mojo_services/lib/mojo/web_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/command_buffer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/native_viewport.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_request.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geocoder.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_message.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_response_disk_cache.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surface_id.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/service_registry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/layouts.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_trees.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/input_event_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/sharing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/display.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_server_socket.mojom.dart
Package mojo_services missing mojo_services/lib/keyboard/keyboard.mojom.dart
Package mojo_services missing mojo_services/lib/input/input.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surfaces.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/host_resolver.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/navigation.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/window_manager_internal.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/contacts/contacts.mojom.dart
Package mojo_services missing
mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_connection.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/udp_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_events.mojom.dart
Package mojo_services missing mojo_services/lib/icu_data/icu_data.mojom.dart
Package mojo_services missing mojo_services/lib/prediction/prediction.mojom.dart
Package mojo_services missing mojo_services/lib/sensors/sensors.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/directory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/types.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_loader_interceptor.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server_factory.mojom.dart
Package mojo_services missing
mojo_services/lib/notifications/notifications.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu_capabilities.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/quads.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/camera.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/view_manager_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/files.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_response.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/context_provider.mojom.dart
Package mojo_services missing
mojo_services/lib/native_support/process.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal_client.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geometry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/clipboard.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/device_info.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/cookie_store.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/animations.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/views.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_bound_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_provider.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_key_codes.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_connected_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/content_handler.mojom.dart
Package mojo_services missing mojo_services/lib/nfc/nfc.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/network_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/file.mojom.dart
Package mojo_services missing
mojo_services/lib/authentication/authentication.mojom.dart
Package mojo_services missing mojo_services/lib/tracing/tracing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/net_address.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo_services.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
Package mojo missing mojo/lib/mojo/url_response.mojom.dart
Package mojo missing mojo/lib/mojo/interface_control_messages.mojom.dart
Package mojo missing mojo/lib/mojo/http_header.mojom.dart
Package mojo missing mojo/lib/mojo/service_provider.mojom.dart
Package mojo missing mojo/lib/mojo/application.mojom.dart
Package mojo missing mojo/lib/mojo/shell.mojom.dart
Package mojo missing mojo/lib/mojo/url_request.mojom.dart
Package mojo missing mojo/lib/mojo/network_error.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/

--- Example output #2 (after touching application.mojom):

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo has old mojo/lib/mojo/application.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
==========

to

==========
Check in generated Dart bindings and add presubmit script

- Add mojom_list_dart_outputs.py script which outputs the path to the generated
bindings file, for example:

Given a foo.mojom file with the following:

[DartPackage="mojo_services"]
module mojo;

The output path is: mojo_services/lib/mojo/foo.mojom.dart

- Add check_mojom_dart.py script which verifies that the generated bindings in
the source tree are updated with respect to their .mojom sources.

- Fix mojom generate.dart script to guess when the mojo/services import path is
needed.
- Fix mojom generate.dart script to better handle case of missing lib/
directory.

---- Example output #1:

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo_services missing mojo_services/lib/mojo/web_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/command_buffer.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/native_viewport.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_request.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geocoder.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_message.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_response_disk_cache.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surface_id.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/viewport_parameter_listener.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/service_registry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/layouts.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_trees.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/input_event_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/sharing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/display.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_server_socket.mojom.dart
Package mojo_services missing mojo_services/lib/keyboard/keyboard.mojom.dart
Package mojo_services missing mojo_services/lib/input/input.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/surfaces.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/host_resolver.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/navigation.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/window_manager_internal.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/contacts/contacts.mojom.dart
Package mojo_services missing
mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_server.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/http_connection.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/udp_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_events.mojom.dart
Package mojo_services missing mojo_services/lib/icu_data/icu_data.mojom.dart
Package mojo_services missing mojo_services/lib/prediction/prediction.mojom.dart
Package mojo_services missing mojo_services/lib/sensors/sensors.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/directory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/types.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/url_loader_interceptor.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_server_factory.mojom.dart
Package mojo_services missing
mojo_services/lib/notifications/notifications.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/gpu_capabilities.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/window_manager.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/quads.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/camera.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/view_manager_constants.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/ioctl.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/files.mojom.dart
Package mojo_services missing
mojo_services/lib/http_server/http_response.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/context_provider.mojom.dart
Package mojo_services missing
mojo_services/lib/native_support/process.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal_client.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/geometry.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/clipboard.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/terminal/terminal.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/url_loader.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/device_info.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/cookie_store.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/location.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/animations.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/views.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/tcp_bound_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/ui/view_provider.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/input_key_codes.mojom.dart
Package mojo_services missing
mojo_services/lib/mojo/tcp_connected_socket.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/content_handler.mojom.dart
Package mojo_services missing mojo_services/lib/nfc/nfc.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/network_service.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/files/file.mojom.dart
Package mojo_services missing
mojo_services/lib/authentication/authentication.mojom.dart
Package mojo_services missing mojo_services/lib/tracing/tracing.mojom.dart
Package mojo_services missing mojo_services/lib/mojo/net_address.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo_services.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
Package mojo missing mojo/lib/mojo/url_response.mojom.dart
Package mojo missing mojo/lib/mojo/interface_control_messages.mojom.dart
Package mojo missing mojo/lib/mojo/http_header.mojom.dart
Package mojo missing mojo/lib/mojo/service_provider.mojom.dart
Package mojo missing mojo/lib/mojo/application.mojom.dart
Package mojo missing mojo/lib/mojo/shell.mojom.dart
Package mojo missing mojo/lib/mojo/url_request.mojom.dart
Package mojo missing mojo/lib/mojo/network_error.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/

--- Example output #2 (after touching application.mojom):

$ ./mojo/dart/tools/presubmit/check_mojom_dart.py 
Package mojo has old mojo/lib/mojo/application.mojom.dart
*** Dart Generated Bindings Check Failed:
You must regenerate bindings for mojo.
From the src directory, run:
$ dart mojo/dart/packages/mojom/bin/mojom.dart gen -m mojo/public -r mojo/
--output mojo/dart/packages/
==========

[Cutch, 2015-11-17 21:55:40]

Committed patchset #3 (id:40001) manually as
ad0bc6d4074c814ec98ae72cff428e5e5393ed3c (presubmit successful).

[Cutch, 2015-11-17 22:56:14]

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
File mojo/dart/tools/presubmit/check_mojom_dart.py (right):

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
mojo/dart/tools/presubmit/check_mojom_dart.py:296: # This list is used to verify
that all updated .mojom.dart files were
On 2015/11/17 18:32:26, jamesr wrote:
> "all updated mojom.dart files were ..." where's the rest of the sentence?

Done.

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
mojo/dart/tools/presubmit/check_mojom_dart.py:321: sys.exit(2)
On 2015/11/17 18:32:26, jamesr wrote:
> i would just return 2 here and propagate that back through main. having only
one
> sys.exit() makes testing easier

Done.

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
mojo/dart/tools/presubmit/check_mojom_dart.py:349: print('OK.')
On 2015/11/17 18:32:26, jamesr wrote:
> no need to print OK if things are good, the exit code will tell you

Done.

https://codereview.chromium.org/1449203002/diff/20001/mojo/dart/tools/presubm...
mojo/dart/tools/presubmit/check_mojom_dart.py:350: sys.exit(0)
On 2015/11/17 18:32:26, jamesr wrote:
> return, line 353 is doing the sys.exit()

Done.