Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: PRESUBMIT.py

Issue 1449203002: Check in generated Dart bindings and add presubmit script (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/dart/packages/mojo/lib/mojo/application.mojom.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 30f1151d063c220e3d934144f4726c57029eca89..d2391d0cd22325f0ed34ee19e4397205818038bd 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1063,11 +1063,30 @@ def _CheckForUsingSideEffectsOfPass(input_api, output_api):
return errors
+def _CheckDartBindings(input_api, output_api):
+ """Check that generated .mojom.dart files are current"""
+ args = [input_api.python_executable,
+ 'mojo/dart/tools/presubmit/check_mojom_dart.py',
+ '--affected-files']
+ files = []
+ for f in input_api.AffectedFiles():
+ files.append(f.LocalPath())
+ args.extend(files)
+ try:
+ input_api.subprocess.check_output(args)
+ return []
+ except input_api.subprocess.CalledProcessError, error:
+ return [output_api.PresubmitError(
+ 'Dart bindings need to be updated.',
+ long_text=error.output)]
+
+
def CheckChangeOnUpload(input_api, output_api):
results = []
results.extend(_CommonChecks(input_api, output_api))
results.extend(_CheckValidHostsInDEPS(input_api, output_api))
results.extend(_CheckJavaStyle(input_api, output_api))
+ results.extend(_CheckDartBindings(input_api, output_api))
results.extend(
input_api.canned_checks.CheckGNFormatted(input_api, output_api))
return results
« no previous file with comments | « no previous file | mojo/dart/packages/mojo/lib/mojo/application.mojom.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698