Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1448913003: [heap] make inline-allocation-observers precise (Closed)

Created:
5 years, 1 month ago by ofrobots
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] make inline-allocation-observers precise Now that we no longer require AllocationInfo::limit to be aligned [1], we can do more accurate inline-allocation-observation. This lets us get notified when the next allocation that crosses the step-size boundary is allocated. Fixed the test-cases. They make significantly more sense now given the step sizes and the number of times we get notifications. For example, with a step size of 512, an allocation of 16kb results in 32 notifications instead of 30 now. [1] https://codereview.chromium.org/1444883003 R=hpayer@chromium.org BUG= Committed: https://crrev.com/0514fa204a39682fbc4ec7de19ac03aac08ee462 Cr-Commit-Position: refs/heads/master@{#32091}

Patch Set 1 #

Patch Set 2 : fix typo in test-case comment #

Total comments: 2

Patch Set 3 : fix comment nits #

Patch Set 4 : Rebase #

Patch Set 5 : Needed to remove the second instance of the limit alignment assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M src/heap/spaces.h View 1 2 3 4 3 chunks +4 lines, -9 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-spaces.cc View 1 3 chunks +9 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
ofrobots
5 years, 1 month ago (2015-11-16 17:28:43 UTC) #1
Hannes Payer (out of office)
lgtm, just comment nits https://codereview.chromium.org/1448913003/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1448913003/diff/20001/src/heap/spaces.h#newcode2525 src/heap/spaces.h:2525: // least step_size byte have ...
5 years, 1 month ago (2015-11-17 14:41:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448913003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448913003/40001
5 years, 1 month ago (2015-11-17 19:47:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/10858)
5 years, 1 month ago (2015-11-17 20:21:57 UTC) #7
ofrobots
On 2015/11/17 20:21:57, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-17 21:20:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448913003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448913003/60001
5 years, 1 month ago (2015-11-17 21:20:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/10864)
5 years, 1 month ago (2015-11-17 21:51:37 UTC) #13
ofrobots
On 2015/11/17 21:51:37, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 1 month ago (2015-11-17 22:02:01 UTC) #14
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-18 08:58:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448913003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448913003/80001
5 years, 1 month ago (2015-11-18 15:27:18 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-18 15:54:28 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 15:55:12 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0514fa204a39682fbc4ec7de19ac03aac08ee462
Cr-Commit-Position: refs/heads/master@{#32091}

Powered by Google App Engine
This is Rietveld 408576698