Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1444883003: [heap] remove alignment requirement from AllocationInfo::limit (Closed)

Created:
5 years, 1 month ago by ofrobots
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] remove alignment requirement from AllocationInfo::limit While all allocated objects need to have correct alignment, this requirement doesn't make a lot of sense for the allocation limit. Removing this assertion would makes it possible to make the inline-allocation-observers accurate. This could be done in other ways, but removing this assertion is the most elegant way to go about it. R=hpayer@chromium.org BUG= Committed: https://crrev.com/a0253e8594176ecb086937be97101c07340dbdcb Cr-Commit-Position: refs/heads/master@{#32013}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/heap/spaces.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ofrobots
5 years, 1 month ago (2015-11-14 00:06:01 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-16 11:31:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1444883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1444883003/1
5 years, 1 month ago (2015-11-16 16:05:00 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-16 16:47:33 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 16:47:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0253e8594176ecb086937be97101c07340dbdcb
Cr-Commit-Position: refs/heads/master@{#32013}

Powered by Google App Engine
This is Rietveld 408576698