Issue 144863003: Doc fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 144863003: Doc fixes (Closed)

Created:
6 years, 10 months ago by Cutch

Modified:
6 years, 10 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Doc fixes BUG= R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=32247

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -34 lines)			Patch
	M	sdk/lib/typed_data/typed_data.dart	View	1	34 chunks	+48 lines, -34 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Excellent! LGTM and thanks. https://codereview.chromium.org/144863003/diff/1/sdk/lib/typed_data/typed_data.dart File sdk/lib/typed_data/typed_data.dart (right): https://codereview.chromium.org/144863003/diff/1/sdk/lib/typed_data/typed_data.dart#newcode954 sdk/lib/typed_data/typed_data.dart:954: Float32x4 upperLimit); Indentation is off. ...

6 years, 10 months ago (2014-02-03 11:54:05 UTC) #2

Cutch

https://codereview.chromium.org/144863003/diff/1/sdk/lib/typed_data/typed_data.dart File sdk/lib/typed_data/typed_data.dart (right): https://codereview.chromium.org/144863003/diff/1/sdk/lib/typed_data/typed_data.dart#newcode954 sdk/lib/typed_data/typed_data.dart:954: Float32x4 upperLimit); On 2014/02/03 11:54:05, Lasse Reichstein Nielsen wrote: ...

6 years, 10 months ago (2014-02-03 16:31:38 UTC) #3

Cutch

6 years, 10 months ago (2014-02-03 16:32:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32247 (presubmit successful).

Expand Messages | Collapse Messages

Issue 144863003: Doc fixes (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages