third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h - Issue 1448353002: Oilpan: move ServiceWorkerGlobalScopeProxy to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

Issue 1448353002: Oilpan: move ServiceWorkerGlobalScopeProxy to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: assert for clean detachment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

index 8c4d9d9817fbff3f36a7a4ae054aeedb5c24a969..55f53bb24681564fb873371d64fe3f77e4cc644c 100644

--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

@@ -107,7 +107,7 @@ private:

RefPtr<WorkerThread> m_workerThread;

RefPtr<WorkerLoaderProxy> m_loaderProxy;

- OwnPtr<ServiceWorkerGlobalScopeProxy> m_workerGlobalScopeProxy;

+ OwnPtrWillBePersistent<ServiceWorkerGlobalScopeProxy> m_workerGlobalScopeProxy;

OwnPtrWillBePersistent<WorkerInspectorProxy> m_workerInspectorProxy;

// 'shadow page' - created to proxy loading requests from the worker.