third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp - Issue 1448353002: Oilpan: move ServiceWorkerGlobalScopeProxy to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

Issue 1448353002: Oilpan: move ServiceWorkerGlobalScopeProxy to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: assert for clean detachment Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

index 7873baa84f5fa79559588832ba2b4724f0cb9112..2a4236d0e2a498a195768475c353f4501554998f 100644

--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp

@@ -108,6 +108,11 @@ WebEmbeddedWorkerImpl::~WebEmbeddedWorkerImpl()

// Detach the client before closing the view to avoid getting called back.

m_mainFrame->setClient(0);

+ if (m_workerGlobalScopeProxy) {

+ m_workerGlobalScopeProxy->detach();

+ m_workerGlobalScopeProxy.clear();

+ }

m_webView->close();

m_mainFrame->close();

if (m_loaderProxy)

« no previous file with comments | « third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h ('k') | no next file » | no next file with comments »