Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1448283004: Add lock-based unbounded queue (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add lock-based unbounded queue ...based on the 2-lock algorithm by M. Scott and M. Michael (1992). BUG=chromium:524425 LOG=N Committed: https://crrev.com/6c85c14845e4199c7ea0ba169b6798d3d6215632 Cr-Commit-Position: refs/heads/master@{#32078}

Patch Set 1 : #

Patch Set 2 : Fix destruction of queue and unittests #

Patch Set 3 : Moved to atomic handling for Node.next #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -0 lines) Patch
A src/locked-queue.h View 1 chunk +43 lines, -0 lines 0 comments Download
A src/locked-queue-inl.h View 1 2 1 chunk +91 lines, -0 lines 0 comments Download
A test/unittests/locked-queue-unittest.cc View 1 1 chunk +90 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Michael Lippautz
PTAL; The plan is to replace the single-producer/single-consumer "UnboundQueue" that is used by the profiler ...
5 years, 1 month ago (2015-11-17 15:38:49 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448283004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448283004/20001
5 years, 1 month ago (2015-11-17 16:09:51 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/10195)
5 years, 1 month ago (2015-11-17 16:27:58 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448283004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448283004/40001
5 years, 1 month ago (2015-11-17 21:23:05 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 21:57:17 UTC) #15
ulan
lgtm
5 years, 1 month ago (2015-11-18 10:28:19 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448283004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448283004/60001
5 years, 1 month ago (2015-11-18 10:29:26 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 1 month ago (2015-11-18 10:54:04 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 10:54:25 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6c85c14845e4199c7ea0ba169b6798d3d6215632
Cr-Commit-Position: refs/heads/master@{#32078}

Powered by Google App Engine
This is Rietveld 408576698