Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1448213002:
Only set -rpath=$ORIGIN in component builds by default. (Closed)
|
Created:
5 years, 1 month ago by Dirk Pranke Modified:
5 years ago CC:
cc-bugs_chromium.org, chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOnly set -rpath=$ORIGIN in component builds by default.
Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).
R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng
Patch Set 1 #Patch Set 2 : refactor to make base_unittests pass #
Messages
Total messages: 27 (12 generated)
lgtm
LGTM
Description was changed from ========== Only set -rpath=$ORIGIN in component builds by default. Statically-linked binaries do not need -rpath=$ORIGIN set, and setting it can be a source of strange security issues (see bug for more details). R=phajdan.jr@chromium.org, thestig@chromium.org BUG=556843 ========== to ========== Only set -rpath=$ORIGIN in component builds by default. Statically-linked binaries do not need -rpath=$ORIGIN set, and setting it can be a source of strange security issues (see bug for more details). R=phajdan.jr@chromium.org, thestig@chromium.org BUG=556843 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng ==========
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org, phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/1448213002/#ps20001 (title: "refactor to make base_unittests pass")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL) linux_chromium_dbg_ng on tryserver.chromium.linux (JOB_FAILED, no build URL)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448213002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, no build URL)
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1448213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1448213002/20001
I'm going to continue this on https://codereview.chromium.org/1514203002
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
closing in favor of https://codereview.chromium.org/1514203002/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
