Only set -rpath=$ORIGIN in component builds by default.

Only set -rpath=$ORIGIN in component builds by default.

Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).

Manually add this to some test binaries that require shared libraries to be loaded from the build directory.

R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng

Forked from http://crrev.com/1448213002

Committed: https://crrev.com/3de132ceb95eb0d1fd40b611374d6868c717d2b4
Cr-Commit-Position: refs/heads/master@{#364877}

[brettw, 2015-12-10 22:57:24]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-10 22:59:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514203002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514203002/1

[brettw, 2015-12-10 23:59:44]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2015-12-10 23:59:44]

This just has a trivial syntax tweak from the previous patch.

[Dirk Pranke, 2015-12-11 00:18:38]

lgtm

[commit-bot: I haz the power, 2015-12-11 00:26:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-11 00:26:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Paweł Hajdan Jr., 2015-12-11 11:22:54]

LGTM

Thanks!

[brettw, 2015-12-11 18:34:56]

Comments and browser tests fix

[brettw, 2015-12-11 18:35:46]

I added a bunch of comments, renamed the config, and added it to browser_tests
(seems to be required for CDM adapter tests).

[brettw, 2015-12-11 18:35:49]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-11 18:35:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1514203002/#ps20001
(title: "Comments and browser tests fix")

[commit-bot: I haz the power, 2015-12-11 18:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514203002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514203002/20001

[commit-bot: I haz the power, 2015-12-11 22:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-11 22:36:11]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2015-12-11 23:45:19]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[brettw, 2015-12-11 23:45:19]

CC jam for Mojo FYI.

[brettw, 2015-12-11 23:45:25]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-12-11 23:45:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1514203002/#ps40001
(title: "Mojo")

[commit-bot: I haz the power, 2015-12-11 23:47:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514203002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514203002/40001

[brettw, 2015-12-12 00:01:10]

Description was changed from

==========
Only set -rpath=$ORIGIN in component builds by default.

Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).

R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng

Forked from http://crrev.com/1448213002
==========

to

==========
Only set -rpath=$ORIGIN in component builds by default.

Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).

Manually add this to some test binaries that require shared libraries to be
loaded from the build directory.

R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng

Forked from http://crrev.com/1448213002
==========

[commit-bot: I haz the power, 2015-12-12 03:28:03]

Description was changed from

==========
Only set -rpath=$ORIGIN in component builds by default.

Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).

Manually add this to some test binaries that require shared libraries to be
loaded from the build directory.

R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng

Forked from http://crrev.com/1448213002
==========

to

==========
Only set -rpath=$ORIGIN in component builds by default.

Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).

Manually add this to some test binaries that require shared libraries to be
loaded from the build directory.

R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng

Forked from http://crrev.com/1448213002
==========

[commit-bot: I haz the power, 2015-12-12 03:28:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-12 03:28:56]

Description was changed from

==========
Only set -rpath=$ORIGIN in component builds by default.

Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).

Manually add this to some test binaries that require shared libraries to be
loaded from the build directory.

R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng

Forked from http://crrev.com/1448213002
==========

to

==========
Only set -rpath=$ORIGIN in component builds by default.

Statically-linked binaries do not need -rpath=$ORIGIN
set, and setting it can be a source of strange security
issues (see bug for more details).

Manually add this to some test binaries that require shared libraries to be
loaded from the build directory.

R=phajdan.jr@chromium.org, thestig@chromium.org
BUG=556843
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_ng

Forked from http://crrev.com/1448213002

Committed: https://crrev.com/3de132ceb95eb0d1fd40b611374d6868c717d2b4
Cr-Commit-Position: refs/heads/master@{#364877}
==========

[commit-bot: I haz the power, 2015-12-12 03:28:57]

Patchset 3 (id:??) landed as
https://crrev.com/3de132ceb95eb0d1fd40b611374d6868c717d2b4
Cr-Commit-Position: refs/heads/master@{#364877}

[Dirk Pranke, 2015-12-12 17:08:04]

On 2015/12/12 03:28:57, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/3de132ceb95eb0d1fd40b611374d6868c717d2b4
> Cr-Commit-Position: refs/heads/master@{#364877}

We should probably merge this back to M48 to be safe.

[dcheng, 2015-12-14 19:20:55]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1525733002/ by dcheng@chromium.org.

The reason for reverting is: Breaks Linux GN components_browsertests:
components_browsertests: error while loading shared libraries:
libblink_test_plugin.so: cannot open shared object file: No such file or
directory.

[dcheng, 2015-12-14 19:25:17]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org, jochen@chromium.org

[dcheng, 2015-12-14 19:25:17]

components_browsertests is picking this dependency up from
//content/shell:content_shell_lib. content_shell_lib depends on the
blink_test_plugin for unit tests... I'm guessing this is related to
//components/test_runner, but I honestly don't know enough about it =/

[brettw, 2015-12-14 20:31:32]

Link to bot?

[dcheng, 2015-12-15 00:29:33]

On 2015/12/14 at 20:31:32, brettw wrote:
> Link to bot?

I don't think any bots were failing, but building locally with only use_goma =
true + this patch, and then trying to run components_unittests will hit this
error.