chrome/test/data/webui/test_api.js - Issue 1447693002: [a11y] Bring accessibility-audit up to date: v2.10.0 release.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/test_api.js

Issue 1447693002: [a11y] Bring accessibility-audit up to date: v2.10.0 release. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactor ignored checks, simplify some selectors, add crbugs. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/options_browsertest.js ('K') | « chrome/test/data/webui/print_preview.js ('k') | third_party/accessibility-audit/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/test_api.js

diff --git a/chrome/test/data/webui/test_api.js b/chrome/test/data/webui/test_api.js

index a4428414559aeb6c3c346536fe40ae3d6ea5677e..f630166c1ebe82d64a10ab97cc4088954c8d01f8 100644

--- a/chrome/test/data/webui/test_api.js

+++ b/chrome/test/data/webui/test_api.js

@@ -172,8 +172,7 @@ var testing = {};

// Further, 'window' is not available in unit tests, but since the

// accessibility audit library pulls in the closure library,

// 'goog.global' has to be present if axs is, so we use that here.

- if (!this.accessibilityAuditConfig_ &&

- goog && goog.global && goog.global.axs) {

+ if (!this.accessibilityAuditConfig_) {

this.accessibilityAuditConfig_ = new axs.AuditConfiguration();

this.accessibilityAuditConfig_.showUnsupportedRulesWarning = false;

@@ -193,6 +192,10 @@ var testing = {};

// TODO(aboxhall): re-enable when crbug.com/267035 is fixed.

// Until then it's just noise.

"lowContrastElements",

+ // TODO(aboxhall): re-enable when following issue is fixed.

+ // github.com/GoogleChrome/accessibility-developer-tools/issues/251

+ "tableHasAppropriateHeaders",

];

}

return this.accessibilityAuditConfig_;