Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: chrome/browser/ui/webui/options/options_browsertest.js

Issue 1447693002: [a11y] Bring accessibility-audit up to date: v2.10.0 release. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor ignored checks, simplify some selectors, add crbugs. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/options_browsertest.js b/chrome/browser/ui/webui/options/options_browsertest.js
index d2c068a626f9acb9173815a5db07cce2c44d0f93..b0a53e20e9c4532d3ac0cd1f94a5ee99379a995a 100644
--- a/chrome/browser/ui/webui/options/options_browsertest.js
+++ b/chrome/browser/ui/webui/options/options_browsertest.js
@@ -79,6 +79,33 @@ OptionsWebUITest.prototype = {
this.mockHandler.stubs().observePrefs(ANYTHING);
this.mockHandler.stubs().coreOptionsUserMetricsAction(ANYTHING);
},
+
+ /** @override */
+ setUp: function() {
+ OptionsBrowsertestBase.prototype.setUp.call(this);
+
+ // Enable when failure is resolved.
+ // AX_ARIA_10: http://crbug.com/559329
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'unsupportedAriaAttribute',
+ '#profiles-list');
+
+ var linkWithUnclearPurposeSelectors = [
+ '#sync-overview > A',
+ '#privacy-explanation > A',
+ '#languages-section > .settings-row > A',
+ '#cloudprint-options-mdns > .settings-row > A',
+ '#do-not-track-confirm-overlay > .action-area > .hbox.stretch > A',
+ ];
+
+ // Enable when failure is resolved.
+ // AX_TEXT_04: http://crbug.com/559318
+ linkWithUnclearPurposeSelectors.forEach(function(selector) {
+ this.accessibilityAuditConfig.ignoreSelectors(
aboxhall 2015/11/20 23:50:06 You should be able to pass linkWithUnclearPurposeS
apacible 2015/11/21 01:29:56 Done.
+ 'linkWithUnclearPurpose',
+ selector);
+ }.bind(this));
+ },
};
/**
@@ -378,6 +405,46 @@ OptionsWebUIExtendedTest.prototype = {
/** @override */
typedefCppFixture: 'OptionsBrowserTest',
+ /** @override */
+ setUp: function() {
+ OptionsWebUITest.prototype.setUp.call(this);
+
+ // Enable when failure is resolved.
+ // AX_ARIA_10: http://crbug.com/559329
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'unsupportedAriaAttribute',
+ '#profiles-list');
+
+ var controlsWithoutLabelSelectors = [
+ '#cookies-view-page > .content-area.cookies-list-content-area > *',
+ '#other-search-engine-list > .deletable-item > DIV > *',
+ ];
+
+ // Enable when failure is resolved.
+ // AX_TEXT_01: http://crbug.com/559330
+ controlsWithoutLabelSelectors.forEach(function(selector) {
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'controlsWithoutLabel',
+ selector);
+ }.bind(this));
+
+
+ var linkWithUnclearPurposeSelectors = [
+ '#sync-overview > A',
+ '#privacy-explanation > A',
+ '#languages-section > .settings-row > A',
+ '#cloudprint-options-mdns > .settings-row > A',
+ ];
+
+ // Enable when failure is resolved.
+ // AX_TEXT_04: http://crbug.com/559326
+ linkWithUnclearPurposeSelectors.forEach(function(selector) {
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'linkWithUnclearPurpose',
+ selector);
+ }.bind(this));
+ },
+
testGenPreamble: function() {
// Start with no supervised users managed by this profile.
GEN(' ClearPref("' + SUPERVISED_USERS_PREF + '");');

Powered by Google App Engine
This is Rietveld 408576698