Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js

Issue 1447693002: [a11y] Bring accessibility-audit up to date: v2.10.0 release. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Refactor ignored checks, simplify some selectors, add crbugs. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
diff --git a/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js b/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
index 56419fa492873e05df364db8cd1f70851cc5bf61..c5e5288f64fa11bb2babcf5fcc29267e3014e036 100644
--- a/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
+++ b/chrome/browser/ui/webui/options/multilanguage_options_webui_browsertest.js
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+GEN_INCLUDE(['options_browsertest_base.js']);
GEN('#include "chrome/browser/ui/webui/options/' +
'multilanguage_options_browsertest.h"');
@@ -13,7 +14,7 @@ GEN('#include "chrome/browser/ui/webui/options/' +
function MultilanguageOptionsWebUIBrowserTest() {}
MultilanguageOptionsWebUIBrowserTest.prototype = {
- __proto__: testing.Test.prototype,
+ __proto__: OptionsBrowsertestBase.prototype,
/** @override */
browsePreload: 'chrome://settings-frame/languages',
@@ -32,7 +33,7 @@ MultilanguageOptionsWebUIBrowserTest.prototype = {
/** @override */
setUp: function() {
- testing.Test.prototype.setUp.call(this);
+ OptionsBrowsertestBase.prototype.setUp.call(this);
assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));
assertFalse(cr.isMac);
@@ -40,6 +41,31 @@ MultilanguageOptionsWebUIBrowserTest.prototype = {
expectFalse($('edit-custom-dictionary-button').hidden);
this.expectEnableSpellcheckCheckboxHidden();
this.expectCurrentlySelected('fr');
+
+ var requiredOwnedAriaRoleMissingSelectors = [
+ '#default-search-engine-list',
+ '#other-search-engine-list',
+ ];
+
+ // Enable when failure is resolved.
+ // AX_ARIA_08: http://crbug.com/559320
+ requiredOwnedAriaRoleMissingSelectors.forEach(function(selector) {
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'requiredOwnedAriaRoleMissing',
+ selector);
+ }.bind(this));
+
+ // Enable when failure is resolved.
+ // AX_ARIA_10: http://crbug.com/559266
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'unsupportedAriaAttribute',
+ '#language-options-list');
+
+ // Enable when failure is resolved.
+ // AX_TEXT_04: http://crbug.com/559271
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'linkWithUnclearPurpose',
+ '#languagePage > .content-area > .language-options-header > A');
},
/** @override */
@@ -140,7 +166,7 @@ MultilanguagePreferenceWebUIBrowserTest.prototype = {
/** @override */
setUp: function() {
- testing.Test.prototype.setUp.call(this);
+ OptionsBrowsertestBase.prototype.setUp.call(this);
assertTrue(loadTimeData.getBoolean('enableMultilingualSpellChecker'));
assertFalse(cr.isMac);
@@ -149,6 +175,18 @@ MultilanguagePreferenceWebUIBrowserTest.prototype = {
this.expectEnableSpellcheckCheckboxHidden();
this.expectCurrentlySelected('');
this.expectRegisteredDictionariesPref('');
+
+ // Enable when failure is resolved.
+ // AX_ARIA_10: http://crbug.com/559266
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'unsupportedAriaAttribute',
+ '#language-options-list');
+
+ // Enable when failure is resolved.
+ // AX_TEXT_04: http://crbug.com/559271
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'linkWithUnclearPurpose',
+ '#languagePage > .content-area > .language-options-header > A');
},
};

Powered by Google App Engine
This is Rietveld 408576698