[a11y] Bring accessibility-audit up to date: v2.10.0 release.

[a11y] Bring accessibility-audit up to date: v2.10.0 release.

This change pulls in the latest a11y devtools release.

With the update of third_party/accessibility_audit to release v2.10.0, a number of browser tests had accessibility audit failures and warnings. These are all disabled/ignored and bugs filed for each set of audit failures.

The accessibility audit repository can be found at: https://github.com/GoogleChrome/accessibility-developer-tools

TBR=sky@chromium.org
BUG=555753
Committed: https://crrev.com/12fdc0a6860f25e24cca86250e8b9d0f17f3cc47
Cr-Commit-Position: refs/heads/master@{#361792}

[apacible, 2015-11-13 21:57:01]

Description was changed from

==========
update accessibility audit

BUG=
==========

to

==========
[a11y] Bring accessibility-audit up to date.

BUG=
==========

[apacible, 2015-11-13 21:57:02]

apacible@chromium.org changed reviewers:
+ thakis@chromium.org

[apacible, 2015-11-13 22:00:45]

Description was changed from

==========
[a11y] Bring accessibility-audit up to date.

BUG=
==========

to

==========
[a11y] Bring accessibility-audit up to date.

BUG=555753
==========

[apacible, 2015-11-13 22:01:21]

apacible@chromium.org changed reviewers:
- thakis@chromium.org

[apacible, 2015-11-14 02:18:26]

Description was changed from

==========
[a11y] Bring accessibility-audit up to date.

BUG=555753
==========

to

==========
[Work In Progress] [a11y] Bring accessibility-audit up to date.

BUG=555753
==========

[apacible, 2015-11-19 18:54:23]

Patchset #4 (id:60001) has been deleted

[apacible, 2015-11-19 19:13:16]

Patchset #5 (id:100001) has been deleted

[apacible, 2015-11-20 00:48:25]

Patchset #5 (id:120001) has been deleted

[apacible, 2015-11-20 00:48:33]

Patchset #4 (id:80001) has been deleted

[apacible, 2015-11-20 01:10:08]

Description was changed from

==========
[Work In Progress] [a11y] Bring accessibility-audit up to date.

BUG=555753
==========

to

==========
[Work In Progress] [a11y] Bring accessibility-audit up to date: v2.10.0 release.

BUG=555753
==========

[apacible, 2015-11-20 02:45:40]

Patchset #4 (id:140001) has been deleted

[apacible, 2015-11-20 03:35:45]

Patchset #4 (id:160001) has been deleted

[apacible, 2015-11-20 22:38:11]

Patchset #5 (id:200001) has been deleted

[apacible, 2015-11-20 22:43:54]

Description was changed from

==========
[Work In Progress] [a11y] Bring accessibility-audit up to date: v2.10.0 release.

BUG=555753
==========

to

==========
[a11y] Bring accessibility-audit up to date: v2.10.0 release. 

This change pulls in the latest a11y devtools release.

With the update of third_party/accessibility_audit to release v2.10.0, a number
of browser tests had accessibility audit failures and warnings. These are all
disabled/ignored and bugs filed for each set of audit failures.

The accessibility audit repository can be found at:
https://github.com/GoogleChrome/accessibility-developer-tools

BUG=555753
==========

[apacible, 2015-11-20 22:43:54]

apacible@chromium.org changed reviewers:
+ aboxhall@chromium.org

[apacible, 2015-11-20 22:47:39]

Disregarding chromevox test failures... PTAL, thanks! I've separated patches
based on our conversations from the past week.

[aboxhall, 2015-11-20 23:50:07]

Mostly LGTM modulo the ChromeVox issue - still trying to chase that up.

https://codereview.chromium.org/1447693002/diff/220001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/220001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/options_browsertest.js:104:
this.accessibilityAuditConfig.ignoreSelectors(
You should be able to pass linkWithUnclearPurposeSelectors to ignoreSelectors()
directly:
https://github.com/GoogleChrome/accessibility-developer-tools/blob/master/src...

(And similarly for other tests in this change.)

If that's not working, let me know!

[apacible, 2015-11-21 01:29:57]

https://codereview.chromium.org/1447693002/diff/220001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/220001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/options_browsertest.js:104:
this.accessibilityAuditConfig.ignoreSelectors(
On 2015/11/20 23:50:06, aboxhall wrote:
> You should be able to pass linkWithUnclearPurposeSelectors to
ignoreSelectors()
> directly:
>
https://github.com/GoogleChrome/accessibility-developer-tools/blob/master/src...
> 
> (And similarly for other tests in this change.)
> 
> If that's not working, let me know!

Done.

[Peter Lundblad, 2015-11-23 12:54:46]

plundblad@chromium.org changed reviewers:
+ plundblad@chromium.org

[Peter Lundblad, 2015-11-23 12:54:47]

https://codereview.chromium.org/1447693002/diff/230015/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1447693002/diff/230015/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:174: // 'goog.global' has to be present if
axs is, so we use that here.
Please update this comment to reflect the change below. When I added the
comment and check you remove here, the tests couldn't runb because the audit
library wasn't included, so axs wasn't available. But now it seems like it is
included all the time?  In any case, since the audit library has stopped
leaking its own closure library, I think including it in all tests should
be harmless.
With this simplification, you could also change the type of this property to
non-nullable and change setUp back to assuem it is not null.

[apacible, 2015-11-23 17:47:30]

Patchset #7 (id:250001) has been deleted

[apacible, 2015-11-23 18:52:55]

Patchset #8 (id:290001) has been deleted

[apacible, 2015-11-24 18:02:55]

Patchset #9 (id:330001) has been deleted

[apacible, 2015-11-24 18:03:46]

https://codereview.chromium.org/1447693002/diff/230015/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1447693002/diff/230015/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:174: // 'goog.global' has to be present if
axs is, so we use that here.
On 2015/11/23 12:54:46, Peter Lundblad wrote:
> Please update this comment to reflect the change below. When I added the
> comment and check you remove here, the tests couldn't runb because the audit
> library wasn't included, so axs wasn't available. But now it seems like it is
> included all the time?  In any case, since the audit library has stopped
> leaking its own closure library, I think including it in all tests should
> be harmless.
> With this simplification, you could also change the type of this property to
> non-nullable and change setUp back to assuem it is not null.

Done.

[apacible, 2015-11-24 19:22:00]

Description was changed from

==========
[a11y] Bring accessibility-audit up to date: v2.10.0 release. 

This change pulls in the latest a11y devtools release.

With the update of third_party/accessibility_audit to release v2.10.0, a number
of browser tests had accessibility audit failures and warnings. These are all
disabled/ignored and bugs filed for each set of audit failures.

The accessibility audit repository can be found at:
https://github.com/GoogleChrome/accessibility-developer-tools

BUG=555753
==========

to

==========
[a11y] Bring accessibility-audit up to date: v2.10.0 release. 

This change pulls in the latest a11y devtools release.

With the update of third_party/accessibility_audit to release v2.10.0, a number
of browser tests had accessibility audit failures and warnings. These are all
disabled/ignored and bugs filed for each set of audit failures.

The accessibility audit repository can be found at:
https://github.com/GoogleChrome/accessibility-developer-tools

TBR=sky@chromium.org
BUG=555753
==========

[apacible, 2015-11-24 19:22:00]

apacible@chromium.org changed reviewers:
+ dbeam@chromium.org, sky@chromium.org

[apacible, 2015-11-24 19:23:20]

OWNERS:
+dbeam for chrome/browser/ui/webui/*
+sky for third_party/* (TBR)

PTAL, thanks!

[sky, 2015-11-24 23:04:43]

How about an OWNERS file for the directory?

[Dan Beam, 2015-11-24 23:24:26]

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/downloads_ui_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/downloads_ui_browsertest.js:124:
BaseDownloadsWebUITest.prototype.updateAccessibilityAuditConfig.call(this);
shouldn't this be BaseDownloadsWebUITest.prototype.setUp.call(this)?

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/autofill_options_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/autofill_options_browsertest.js:46: },
this is the same as... this not existing at all

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/content_options_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/content_options_browsertest.js:26: },
remove

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/options_browsertest.js:427: 
remove extra newline

https://codereview.chromium.org/1447693002/diff/350001/chrome/test/data/webui...
File chrome/test/data/webui/history_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/test/data/webui...
chrome/test/data/webui/history_browsertest.js:787: '#notification-bar > A');
indent wrong

https://codereview.chromium.org/1447693002/diff/350001/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:195: // TODO(aboxhall): re-enable when
following issue is fixed.
TODO(author)

[apacible, 2015-11-25 19:13:53]

Added an OWNERS file with aboxhall@ (thanks!).

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/downloads_ui_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/downloads_ui_browsertest.js:124:
BaseDownloadsWebUITest.prototype.updateAccessibilityAuditConfig.call(this);
On 2015/11/24 23:24:26, Dan Beam wrote:
> shouldn't this be BaseDownloadsWebUITest.prototype.setUp.call(this)?

No, this is intended. BaseDownloadsWebUITest's setUp() adds download entries,
but we don't want any of that setup in EmptyDownloadsWebUITest.

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/autofill_options_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/autofill_options_browsertest.js:46: },
On 2015/11/24 23:24:26, Dan Beam wrote:
> this is the same as... this not existing at all

Removed here and below.

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/content_options_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/content_options_browsertest.js:26: },
On 2015/11/24 23:24:26, Dan Beam wrote:
> remove

Done.

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/options/options_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/options/options_browsertest.js:427: 
On 2015/11/24 23:24:26, Dan Beam wrote:
> remove extra newline

Done.

https://codereview.chromium.org/1447693002/diff/350001/chrome/test/data/webui...
File chrome/test/data/webui/history_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/test/data/webui...
chrome/test/data/webui/history_browsertest.js:787: '#notification-bar > A');
On 2015/11/24 23:24:26, Dan Beam wrote:
> indent wrong

Done.

https://codereview.chromium.org/1447693002/diff/350001/chrome/test/data/webui...
File chrome/test/data/webui/test_api.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/test/data/webui...
chrome/test/data/webui/test_api.js:195: // TODO(aboxhall): re-enable when
following issue is fixed.
On 2015/11/24 23:24:26, Dan Beam wrote:
> TODO(author)

Done.

[Dan Beam, 2015-11-25 20:23:04]

lgtm

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/downloads_ui_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/downloads_ui_browsertest.js:124:
BaseDownloadsWebUITest.prototype.updateAccessibilityAuditConfig.call(this);
On 2015/11/25 19:13:53, apacible wrote:
> On 2015/11/24 23:24:26, Dan Beam wrote:
> > shouldn't this be BaseDownloadsWebUITest.prototype.setUp.call(this)?
> 
> No, this is intended. BaseDownloadsWebUITest's setUp() adds download entries,
> but we don't want any of that setup in EmptyDownloadsWebUITest.

ah.  shows how much I remember (I actually wrote the code, I think, lol)

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/downloads_ui_browsertest.js:124:
BaseDownloadsWebUITest.prototype.updateAccessibilityAuditConfig.call(this);
can this be just

  this.updateAccessibilityAuditConfig();

?

[sky, 2015-11-25 21:15:03]

LGTM

[apacible, 2015-11-25 21:59:34]

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/downloads_ui_browsertest.js (right):

https://codereview.chromium.org/1447693002/diff/350001/chrome/browser/ui/webu...
chrome/browser/ui/webui/downloads_ui_browsertest.js:124:
BaseDownloadsWebUITest.prototype.updateAccessibilityAuditConfig.call(this);
On 2015/11/25 20:23:04, Dan Beam wrote:
> can this be just
> 
>   this.updateAccessibilityAuditConfig();
> 
> ?

Done.

[apacible, 2015-11-26 01:02:51]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-11-26 01:02:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
aboxhall@chromium.org, sky@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1447693002/#ps390001
(title: "Changes per dbeam@'s comment.")

[commit-bot: I haz the power, 2015-11-26 01:08:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1447693002/390001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1447693002/390001

[commit-bot: I haz the power, 2015-11-26 02:16:45]

Description was changed from

==========
[a11y] Bring accessibility-audit up to date: v2.10.0 release. 

This change pulls in the latest a11y devtools release.

With the update of third_party/accessibility_audit to release v2.10.0, a number
of browser tests had accessibility audit failures and warnings. These are all
disabled/ignored and bugs filed for each set of audit failures.

The accessibility audit repository can be found at:
https://github.com/GoogleChrome/accessibility-developer-tools

TBR=sky@chromium.org
BUG=555753
==========

to

==========
[a11y] Bring accessibility-audit up to date: v2.10.0 release. 

This change pulls in the latest a11y devtools release.

With the update of third_party/accessibility_audit to release v2.10.0, a number
of browser tests had accessibility audit failures and warnings. These are all
disabled/ignored and bugs filed for each set of audit failures.

The accessibility audit repository can be found at:
https://github.com/GoogleChrome/accessibility-developer-tools

TBR=sky@chromium.org
BUG=555753
==========

[commit-bot: I haz the power, 2015-11-26 02:16:46]

Committed patchset #11 (id:390001)

[commit-bot: I haz the power, 2015-11-26 02:18:20]

Description was changed from

==========
[a11y] Bring accessibility-audit up to date: v2.10.0 release. 

This change pulls in the latest a11y devtools release.

With the update of third_party/accessibility_audit to release v2.10.0, a number
of browser tests had accessibility audit failures and warnings. These are all
disabled/ignored and bugs filed for each set of audit failures.

The accessibility audit repository can be found at:
https://github.com/GoogleChrome/accessibility-developer-tools

TBR=sky@chromium.org
BUG=555753
==========

to

==========
[a11y] Bring accessibility-audit up to date: v2.10.0 release.

This change pulls in the latest a11y devtools release.

With the update of third_party/accessibility_audit to release v2.10.0, a number
of browser tests had accessibility audit failures and warnings. These are all
disabled/ignored and bugs filed for each set of audit failures.

The accessibility audit repository can be found at:
https://github.com/GoogleChrome/accessibility-developer-tools

TBR=sky@chromium.org
BUG=555753

Committed: https://crrev.com/12fdc0a6860f25e24cca86250e8b9d0f17f3cc47
Cr-Commit-Position: refs/heads/master@{#361792}
==========

[commit-bot: I haz the power, 2015-11-26 02:18:21]

Patchset 11 (id:??) landed as
https://crrev.com/12fdc0a6860f25e24cca86250e8b9d0f17f3cc47
Cr-Commit-Position: refs/heads/master@{#361792}

[raymes, 2015-11-26 05:06:28]

A revert of this CL (patchset #11 id:390001) has been created in
https://codereview.chromium.org/1481723002/ by raymes@chromium.org.

The reason for reverting is: This looks like it might have caused a build
breakage:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

[aboxhall, 2015-11-26 17:00:07]

On 2015/11/26 05:06:28, raymes wrote:
> A revert of this CL (patchset #11 id:390001) has been created in
> https://codereview.chromium.org/1481723002/ by mailto:raymes@chromium.org.
> 
> The reason for reverting is: This looks like it might have caused a build
> breakage:
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

Looks like it might be timing out on that builder. I wonder what the significant
differences are:
- between those builders and the majority which pass
- between the updated library and the old one

[apacible, 2015-12-01 22:02:38]

On 2015/11/26 17:00:07, aboxhall wrote:
> On 2015/11/26 05:06:28, raymes wrote:
> > A revert of this CL (patchset #11 id:390001) has been created in
> > https://codereview.chromium.org/1481723002/ by mailto:raymes@chromium.org.
> > 
> > The reason for reverting is: This looks like it might have caused a build
> > breakage:
> >
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....
> 
> Looks like it might be timing out on that builder. I wonder what the
significant
> differences are:
> - between those builders and the majority which pass
> - between the updated library and the old one

Looks like the timed out tests are all hanging at this line:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/w...