Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: chrome/test/data/webui/test_api.js

Issue 1447693002: [a11y] Bring accessibility-audit up to date: v2.10.0 release. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per dbeam@'s comment. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/print_preview.js ('k') | third_party/accessibility-audit/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/test_api.js
diff --git a/chrome/test/data/webui/test_api.js b/chrome/test/data/webui/test_api.js
index 4c2243ed28bc47fe9da42cd09f92ef429214ac66..248929b7b12a3db8d7eab93336e763a0ab4fc5de 100644
--- a/chrome/test/data/webui/test_api.js
+++ b/chrome/test/data/webui/test_api.js
@@ -168,15 +168,10 @@ var testing = {};
/**
* Returns the configuration for the accessibility audit, creating it
* on-demand.
- * @return {axs.AuditConfiguration}
+ * @return {!axs.AuditConfiguration}
*/
get accessibilityAuditConfig() {
- // The axs namespace is not available in chromevox tests.
- // Further, 'window' is not available in unit tests, but since the
- // accessibility audit library pulls in the closure library,
- // 'goog.global' has to be present if axs is, so we use that here.
- if (!this.accessibilityAuditConfig_ &&
- goog && goog.global && goog.global.axs) {
+ if (!this.accessibilityAuditConfig_) {
this.accessibilityAuditConfig_ = new axs.AuditConfiguration();
this.accessibilityAuditConfig_.showUnsupportedRulesWarning = false;
@@ -196,6 +191,10 @@ var testing = {};
// TODO(aboxhall): re-enable when crbug.com/267035 is fixed.
// Until then it's just noise.
"lowContrastElements",
+
+ // TODO(apacible): re-enable when following issue is fixed.
+ // github.com/GoogleChrome/accessibility-developer-tools/issues/251
+ "tableHasAppropriateHeaders",
];
}
return this.accessibilityAuditConfig_;
@@ -307,17 +306,14 @@ var testing = {};
* @type {Function}
*/
setUp: function() {
- var auditConfig = this.accessibilityAuditConfig;
- if (auditConfig) {
- // These should be ignored in many of the web UI tests.
- // user-image-stream and supervised-user-creation-image-stream are
- // streaming video elements used for capturing a user image so they
- // won't have captions and should be ignored everywhere.
- auditConfig.ignoreSelectors('videoWithoutCaptions',
- '.user-image-stream');
- auditConfig.ignoreSelectors(
- 'videoWithoutCaptions', '.supervised-user-creation-image-stream');
- }
+ // These should be ignored in many of the web UI tests.
+ // user-image-stream and supervised-user-creation-image-stream are
+ // streaming video elements used for capturing a user image so they
+ // won't have captions and should be ignored everywhere.
+ this.accessibilityAuditConfig.ignoreSelectors('videoWithoutCaptions',
+ '.user-image-stream');
+ this.accessibilityAuditConfig.ignoreSelectors(
+ 'videoWithoutCaptions', '.supervised-user-creation-image-stream');
},
/**
« no previous file with comments | « chrome/test/data/webui/print_preview.js ('k') | third_party/accessibility-audit/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698