Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1447463002: depot_tools: move some checks from commit to upload (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
M-A Ruel, pgervais
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

depot_tools: move some checks from commit to upload BUG=553681 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M presubmit_canned_checks.py View 1 chunk +6 lines, -8 lines 0 comments Download
M tests/presubmit_unittest.py View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-13 14:54:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447463002/1
5 years, 1 month ago (2015-11-13 14:55:48 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 14:57:25 UTC) #6
M-A Ruel
Rationale?
5 years, 1 month ago (2015-11-13 19:09:51 UTC) #7
pgervais
On 2015/11/13 19:09:51, M-A Ruel wrote: > Rationale? lgtm, Adding licence headers should be caught ...
5 years, 1 month ago (2015-11-16 08:22:49 UTC) #8
Paweł Hajdan Jr.
On 2015/11/13 at 19:09:51, maruel wrote: > Rationale? Please see bug. We could continue discussion ...
5 years, 1 month ago (2015-11-16 09:45:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447463002/1
5 years, 1 month ago (2015-11-16 09:45:15 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 09:46:57 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297559

Powered by Google App Engine
This is Rietveld 408576698