Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: presubmit_canned_checks.py

Issue 1447463002: depot_tools: move some checks from commit to upload (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_canned_checks.py
diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py
index c04f84cf01fc7fcc6d775bacfc26c41f6483b1f6..5247f1dc982a3c83fdfafe6195dd1ba39dd796d3 100644
--- a/presubmit_canned_checks.py
+++ b/presubmit_canned_checks.py
@@ -1103,19 +1103,17 @@ def PanProjectChecks(input_api, output_api,
snapshot("checking nsobjects")
results.extend(_CheckConstNSObject(
input_api, output_api, source_file_filter=sources))
+ snapshot("checking eol style")
+ results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
+ input_api, output_api, source_file_filter=text_files))
+ snapshot("checking license")
+ results.extend(input_api.canned_checks.CheckLicense(
+ input_api, output_api, license_header, source_file_filter=sources))
- # The following checks are only done on commit, since the commit bot will
- # auto-fix most of these.
if input_api.is_committing:
- snapshot("checking eol style")
- results.extend(input_api.canned_checks.CheckChangeSvnEolStyle(
- input_api, output_api, source_file_filter=text_files))
snapshot("checking svn mime types")
results.extend(input_api.canned_checks.CheckSvnForCommonMimeTypes(
input_api, output_api))
- snapshot("checking license")
- results.extend(input_api.canned_checks.CheckLicense(
- input_api, output_api, license_header, source_file_filter=sources))
snapshot("checking was uploaded")
results.extend(input_api.canned_checks.CheckChangeWasUploaded(
input_api, output_api))
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698