Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1447453002: Add explicit compile targets to FYI Clang builders (Closed)

Created:
5 years, 1 month ago by Paweł Hajdan Jr.
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org, hans
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add explicit compile targets to FYI Clang builders Similar to https://codereview.chromium.org/1370213002 but doesn't remove the add_tests_as_compile_targets special case. BUG=536186 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297561

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+378 lines, -28 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 24 chunks +72 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxUBSanVptr.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux__dbg_.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dll_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD64.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLD64dbg.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLDdbg.json View 1 chunk +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg.json View 1 chunk +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_rel.json View 1 chunk +54 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_rel_analyze.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg.json View 1 chunk +79 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_rel.json View 1 chunk +54 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_rel_analyze.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Paweł Hajdan Jr.
5 years, 1 month ago (2015-11-13 14:07:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447453002/20001
5 years, 1 month ago (2015-11-13 14:07:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 14:10:25 UTC) #6
Nico
hey, that's a cool idea, thanks. lgtm assuming the build line looks just like `ninja ...
5 years, 1 month ago (2015-11-13 19:46:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447453002/20001
5 years, 1 month ago (2015-11-16 10:09:00 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 10:11:47 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297561

Powered by Google App Engine
This is Rietveld 408576698