Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1370213002: Add explicit compile targets to all Win and ToT Clang builders (Closed)

Created:
5 years, 2 months ago by hans
Modified:
5 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add explicit compile targets to all Win and ToT Clang builders Trying to fix our bots after https://codereview.chromium.org/1376453002/ deliberately broke them :-( BUG=536186 TBR=sergiyb, phajdan.jr Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296909

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3094 lines, -269 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 40 chunks +75 lines, -69 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan.json View 1 chunk +73 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux.json View 1 chunk +138 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan.json View 1 chunk +138 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux__dbg_.json View 1 chunk +87 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json View 1 chunk +138 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json View 1 chunk +139 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json View 1 chunk +87 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json View 1 chunk +164 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json View 1 chunk +164 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg_.json View 1 chunk +161 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll_.json View 1 chunk +161 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg_.json View 1 chunk +161 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll_.json View 1 chunk +161 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTiOS.json View 1 chunk +13 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json View 1 chunk +103 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64.json View 1 chunk +103 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg_.json View 1 chunk +62 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dll_.json View 1 chunk +100 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD.json View 1 chunk +106 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD64.json View 1 chunk +106 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg_.json View 1 chunk +100 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json View 1 chunk +100 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLD64dbg.json View 1 chunk +106 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLDdbg.json View 1 chunk +106 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg.json View 1 chunk +51 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_dbg_analyze.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_rel.json View 1 chunk +54 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_rel_analyze.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg.json View 1 chunk +79 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_dbg_analyze.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_rel.json View 1 chunk +54 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_clang_x64_rel_analyze.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370213002/1
5 years, 2 months ago (2015-09-28 16:58:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296909
5 years, 2 months ago (2015-09-28 17:01:05 UTC) #4
Nico
5 years, 2 months ago (2015-09-28 18:14:57 UTC) #5
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1371203002/ by thakis@chromium.org.

The reason for reverting is: Shouldn't be needed,
https://codereview.chromium.org/1376453002/ is just wrong.

Powered by Google App Engine
This is Rietveld 408576698