ExternalDataUseObserver matches package names

chrome/browser/android/data_usage/external_data_use_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
 #define CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_
 
 #include <jni.h>
 #include <stdint.h>
 
@@ skipping 73 matching lines @@
   // called on a different thread. |success| is true if the request was
   // successfully submitted to the external data use observer by Java. Must be
   // called on UI thread.
   void OnReportDataUseDone(JNIEnv* env, jobject obj, bool success);
 
   // Returns true if the |gurl| matches the registered regular expressions.
   // |label| must not be null. If a match is found, the |label| is set to the
   // matching rule's label.
   bool Matches(const GURL& gurl, std::string* label) const;
 
+  // Returns true if the |app_package_name| matches the registered package
+  // names. |label| must not be null. If a match is found, the |label| is set

[Raj, 2015/11/18 18:36:51]

nits:
change |label| to |output_label| for more clarity.

[tbansal1, 2015/11/18 18:50:50]

I think it is clear that since it is a pointer and from the comments, that it
will be modified.

+  // to the matching rule's label.
+  bool MatchesAppPackageName(const std::string& app_package_name,
+                             std::string* label) const;
+
   DataUseTabModel* data_use_tab_model() const {
     return data_use_tab_model_.get();
   }
 
  private:
   friend class ExternalDataUseObserverTest;
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, SingleRegex);
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, TwoRegex);
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, MultipleRegex);
   FRIEND_TEST_ALL_PREFIXES(ExternalDataUseObserverTest, ChangeRegex);
@@ skipping 72 matching lines @@
 
   // Stores the matching rules.
   class MatchingRule {
    public:
     MatchingRule(const std::string& app_package_name,
                  scoped_ptr<re2::RE2> pattern,
                  const std::string& label);
     ~MatchingRule();
 
     const re2::RE2* pattern() const;
+    const std::string& app_package_name() const;

[Raj, 2015/11/18 18:36:51]

nits:
If its only used in tests, consider making the test class as friend to
MatchingRule.
Not sure if this is intended to be used by new code.

[tbansal1, 2015/11/18 18:50:50]

this is used in external_data_use_observer.cc

     const std::string& label() const;
 
    private:
     // Package name of the app that should be matched.
     const std::string app_package_name_;
 
     // RE2 pattern to match against URLs.
     scoped_ptr<re2::RE2> pattern_;
 
     // Opaque label that uniquely identifies this matching rule.
@@ skipping 126 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ExternalDataUseObserver);
 };
 
 bool RegisterExternalDataUseObserver(JNIEnv* env);
 
 }  // namespace android
 
 }  // namespace chrome
 
 #endif  // CHROME_BROWSER_ANDROID_DATA_USAGE_EXTERNAL_DATA_USE_OBSERVER_H_