Add debug loggings to figure out a snackbar crash

Add debug loggings to figure out a snackbar crash

This CL adds loggings about activity state and prints stacktrace about
how the popup window's view is detached from the window.

BUG=553569
Committed: https://crrev.com/83557154975fb266458aa974a0e8c5e02fd57f8c
Cr-Commit-Position: refs/heads/master@{#360274}

[Ian Wen, 2015-11-17 00:28:06]

ianwen@chromium.org changed reviewers:
+ newt@chromium.org

[Ian Wen, 2015-11-17 00:28:07]

PTAL

[newt (away), 2015-11-17 22:48:23]

lgtm with suggestion

https://codereview.chromium.org/1447313002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://codereview.chromium.org/1447313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:50:
* called.
Add TODO to remove this

https://codereview.chromium.org/1447313002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:185:
public void dismissAllSnackbars(boolean isTimeout) {
Suggestion: don't change the constructor for this class. Just add a new method
that takes the activity and does the logging.

  dismissAllSnackbarsWithLogging(boolean isTimeout, Activity activity) {
    try {
        dismissAllSnackbars(isTimeout);
    } catch (Exception ex) {
        android.util.Log.d(TAG, "Activity.toString()? " + mActivity);
        ...
        if (sWindowDetachTrace != null) android.util.Log.d(...,
sWindowDetachTrace);
        throw ex;
    }
  }

[Ian Wen, 2015-11-18 01:36:41]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-11-18 01:36:42]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1447313002/#ps20001
(title: "respond to newt's comments")

[Ian Wen, 2015-11-18 01:36:55]

All done.

[commit-bot: I haz the power, 2015-11-18 01:38:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1447313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1447313002/20001

[newt (away), 2015-11-18 01:45:09]

The CQ bit was unchecked by newt@chromium.org

[newt (away), 2015-11-18 01:46:54]

one more change needed

https://codereview.chromium.org/1447313002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://codereview.chromium.org/1447313002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:201:
throw sWindowDetachTrace;
If you throw sWindowDetachTrace then Chrome will crash immediately and the
IllegalArgumentException ex won't be thrown. Not what we want.

Instead, you should log sWindowDetachTrace:

    android.util.Log.d(TAG, "blah blah", sWindowDetachTrace);

[Ian Wen, 2015-11-18 01:55:47]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2015-11-18 01:55:47]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1447313002/#ps40001
(title: "nit")

[Ian Wen, 2015-11-18 01:56:26]

https://codereview.chromium.org/1447313002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java
(right):

https://codereview.chromium.org/1447313002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java:201:
throw sWindowDetachTrace;
On 2015/11/18 01:46:54, newt wrote:
> If you throw sWindowDetachTrace then Chrome will crash immediately and the
> IllegalArgumentException ex won't be thrown. Not what we want.
> 
> Instead, you should log sWindowDetachTrace:
> 
>     android.util.Log.d(TAG, "blah blah", sWindowDetachTrace);

Done.

[commit-bot: I haz the power, 2015-11-18 01:56:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1447313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1447313002/40001

[commit-bot: I haz the power, 2015-11-18 02:46:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-18 02:46:43]

Patchset 3 (id:??) landed as
https://crrev.com/83557154975fb266458aa974a0e8c5e02fd57f8c
Cr-Commit-Position: refs/heads/master@{#360274}