chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java - Issue 1447313002: Add debug loggings to figure out a snackbar crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java

Issue 1447313002: Add debug loggings to figure out a snackbar crash (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java

index 26d922ff6e1e05be2359569d335b283cc1ddcf0a..f4975e3988b55c12583a7d89b4c3ff5142547cec 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActivity.java

@@ -33,7 +33,7 @@ public class EnhancedBookmarkActivity extends EnhancedBookmarkActivityBase imple

protected void onCreate(Bundle savedInstanceState) {

super.onCreate(savedInstanceState);

getWindow().clearFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_BACKGROUNDS);

- mSnackbarManager = new SnackbarManager(getWindow());

+ mSnackbarManager = new SnackbarManager(this);

mBookmarkManager = new EnhancedBookmarkManager(this);

setContentView(mBookmarkManager.getView());

EnhancedBookmarkUtils.setTaskDescriptionInDocumentMode(this, getString(

@@ -45,6 +45,12 @@ public class EnhancedBookmarkActivity extends EnhancedBookmarkActivityBase imple

}

@Override

+ protected void onStop() {

+ super.onStop();

+ mSnackbarManager.dismissAllSnackbars(false);

+ }

+ @Override

protected void onDestroy() {

super.onDestroy();

mBookmarkManager.destroy();