Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1447273004: trim some fat from SSE2 fixed point alpha code (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

trim some fat from SSE2 fixed point alpha code - extract alpha from a pixel: 5 1-cycle ops to 4 1-cycle ops - load alphas: drop 4 unnecessary ops Should be no pixel diffs. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/f769c1f80e12e595885376a03f1b99918f2fcd56

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/opts/Sk4px_SSE2.h View 1 chunk +6 lines, -7 lines 1 comment Download
M src/opts/SkPx_sse.h View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447273004/1
5 years, 1 month ago (2015-11-17 19:33:54 UTC) #3
mtklein_C
5 years, 1 month ago (2015-11-17 19:44:19 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-17 19:45:57 UTC) #7
msarett
lgtm https://codereview.chromium.org/1447273004/diff/1/src/opts/Sk4px_SSE2.h File src/opts/Sk4px_SSE2.h (right): https://codereview.chromium.org/1447273004/diff/1/src/opts/Sk4px_SSE2.h#newcode66 src/opts/Sk4px_SSE2.h:66: // We exploit that A >= rgb for ...
5 years, 1 month ago (2015-11-17 19:59:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447273004/1
5 years, 1 month ago (2015-11-17 20:05:23 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 20:05:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f769c1f80e12e595885376a03f1b99918f2fcd56

Powered by Google App Engine
This is Rietveld 408576698