Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: src/opts/SkPx_sse.h

Issue 1447273004: trim some fat from SSE2 fixed point alpha code (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/opts/Sk4px_SSE2.h ('K') | « src/opts/Sk4px_SSE2.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/opts/SkPx_sse.h
diff --git a/src/opts/SkPx_sse.h b/src/opts/SkPx_sse.h
index 1130b310c2d04ec1a70199a137cf09b5b4272d86..2560946edb94e7bf46e6c0c68e023e3bc3955e45 100644
--- a/src/opts/SkPx_sse.h
+++ b/src/opts/SkPx_sse.h
@@ -61,10 +61,9 @@ struct SkPx {
#if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_SSSE3
return _mm_shuffle_epi8(as, _mm_set_epi8(3,3,3,3, 2,2,2,2, 1,1,1,1, 0,0,0,0));
#else
- as = _mm_unpacklo_epi8 (as, _mm_setzero_si128()); // ____ ____ _3_2 _1_0
- as = _mm_unpacklo_epi16(as, _mm_setzero_si128()); // ___3 ___2 ___1 ___0
- as = _mm_or_si128(as, _mm_slli_si128(as, 1)); // __33 __22 __11 __00
- return _mm_or_si128(as, _mm_slli_si128(as, 2)); // 3333 2222 1111 0000
+ as = _mm_unpacklo_epi8 (as, as); // ____ ____ 3322 1100
+ as = _mm_unpacklo_epi16(as, as); // 3333 2222 1111 0000
+ return as;
#endif
}
static Alpha Load(const uint8_t* a, int n) {
@@ -108,9 +107,11 @@ struct SkPx {
#if SK_CPU_SSE_LEVEL >= SK_CPU_SSE_LEVEL_SSSE3
return _mm_shuffle_epi8(fVec, _mm_set_epi8(15,15,15,15, 11,11,11,11, 7,7,7,7, 3,3,3,3));
#else
- __m128i as = _mm_srli_epi32(fVec, 24); // ___3 ___2 ___1 ___0
- as = _mm_or_si128(as, _mm_slli_si128(as, 1)); // __33 __22 __11 __00
- return _mm_or_si128(as, _mm_slli_si128(as, 2)); // 3333 2222 1111 0000
+ // We exploit that A >= rgb for any premul pixel.
+ __m128i as = fVec; // 3xxx 2xxx 1xxx 0xxx
+ as = _mm_max_epu8(as, _mm_srli_epi32(as, 8)); // 33xx 22xx 11xx 00xx
+ as = _mm_max_epu8(as, _mm_srli_epi32(as, 16)); // 3333 2222 1111 0000
+ return as;
#endif
}
« src/opts/Sk4px_SSE2.h ('K') | « src/opts/Sk4px_SSE2.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698