Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: mojo/public/cpp/environment/environment.h

Issue 1447273002: Mojo Log service and a thread-safe client library. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: make min log level consistent with fallback logger, fix thread-safety, address trung's other commen… Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/environment/environment.h
diff --git a/mojo/public/cpp/environment/environment.h b/mojo/public/cpp/environment/environment.h
index 85d17992c0a865f6f4f5e2b0a5a34ecef5c4e931..198e3b127f251ef63b3638ce4660a3b8de116adb 100644
--- a/mojo/public/cpp/environment/environment.h
+++ b/mojo/public/cpp/environment/environment.h
@@ -31,6 +31,7 @@ class Environment {
static const MojoAsyncWaiter* GetDefaultAsyncWaiter();
+ // TODO(vardhan): Require that this logger is thread-safe.
viettrungluu 2015/12/17 18:34:39 It occurs to me that ... I'm not *that* stupid. I
vardhan 2015/12/17 23:35:42 Done.
static const MojoLogger* GetDefaultLogger();
// Setting the logger to null will use the standard implementation.
static void SetDefaultLogger(const MojoLogger* logger);

Powered by Google App Engine
This is Rietveld 408576698