Mojo Log service and a thread-safe client library.

mojo/public/cpp/environment/environment.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_
 #define MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_
 
 #include "mojo/public/cpp/system/macros.h"
 
 struct MojoAsyncWaiter;
@@ skipping 13 matching lines @@
  public:
   Environment();
   // This constructor allows the standard implementations to be overridden (set
   // a parameter to null to get the standard implementation).
   Environment(const MojoAsyncWaiter* default_async_waiter,
               const MojoLogger* default_logger);
   ~Environment();
 
   static const MojoAsyncWaiter* GetDefaultAsyncWaiter();
 
+  // TODO(vardhan):  Require that this logger is thread-safe.

[viettrungluu, 2015/12/17 18:34:39]

It occurs to me that ... I'm not *that* stupid.

In the definition of MojoLogger (//mojo/public/c/environment/logger.h), the
thread-safety requirements are precisely defined.

(Basically, it says that things are thread-safe, except for
SetMinimumLogLevel(), which must not be called concurrently with other stuff.)

So you can remove this TODO.

[vardhan, 2015/12/17 23:35:42]

Done.

   static const MojoLogger* GetDefaultLogger();
   // Setting the logger to null will use the standard implementation.
   static void SetDefaultLogger(const MojoLogger* logger);
 
   // These instantiate and destroy an environment-specific run loop for the
   // current thread, allowing |GetDefaultAsyncWaiter()| to be used. (The run
   // loop itself should be accessible via thread-local storage, using methods
   // specific to the run loop implementation.) Creating and destroying nested
   // run loops is not supported.
   static void InstantiateDefaultRunLoop();
   static void DestroyDefaultRunLoop();
 
  private:
   MOJO_DISALLOW_COPY_AND_ASSIGN(Environment);
 };
 
 }  // namespace mojo
 
 #endif  // MOJO_PUBLIC_CPP_ENVIRONMENT_ENVIRONMENT_H_