Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Issue 1447113002: Optionally pass rendertarget to getTestTarget (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Optionally pass rendertarget to getTestTarget This shouldn't really make any difference but allocating and holding on to a GrRenderTarget for each test target generates image differences for Mali GPUs. This CL allows an existing render target to be used for the test target. TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/504ce5dc772e14be2f5697b00ac82fcf82127763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -30 lines) Patch
M gm/beziereffects.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M gm/bigrrectaaeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/constcolorprocessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/rrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/yuvtorgbeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +16 lines, -13 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
robertphillips
5 years, 1 month ago (2015-11-16 18:46:43 UTC) #3
joshualitt
On 2015/11/16 18:46:43, robertphillips wrote: lgtm
5 years, 1 month ago (2015-11-16 18:47:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447113002/1
5 years, 1 month ago (2015-11-16 18:48:46 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-16 19:01:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1447113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1447113002/1
5 years, 1 month ago (2015-11-16 19:01:35 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 19:02:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/504ce5dc772e14be2f5697b00ac82fcf82127763

Powered by Google App Engine
This is Rietveld 408576698