Issue 14471035: Avoid unnecessary indirection when creating CodeEntries

Issue 14471035: Avoid unnecessary indirection when creating CodeEntries (Closed)

Created:
7 years, 8 months ago by yurys

Modified:
7 years, 8 months ago

Reviewers:
Jakob Kummerow, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Avoid unnecessary indirection when creating CodeEntries BUG=None Committed: https://code.google.com/p/v8/source/detail?r=14446

Patch Set 2 : Fixed nit #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -47 lines)			Patch
M	src/cpu-profiler.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/cpu-profiler.cc	View		8 chunks	+10 lines, -8 lines	0 comments	Download
M	src/profile-generator.h	View		1 chunk	+0 lines, -27 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	test/cctest/test-profile-generator.cc	View		3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with a nit. https://codereview.chromium.org/14471035/diff/1/src/cpu-profiler.h File src/cpu-profiler.h (right): https://codereview.chromium.org/14471035/diff/1/src/cpu-profiler.h#newcode128 src/cpu-profiler.h:128: explicit ProfilerEventsProcessor(ProfileGenerator* generator, nit: "explicit" ...

7 years, 8 months ago (2013-04-25 16:06:39 UTC) #3

yurys

https://codereview.chromium.org/14471035/diff/1/src/cpu-profiler.h File src/cpu-profiler.h (right): https://codereview.chromium.org/14471035/diff/1/src/cpu-profiler.h#newcode128 src/cpu-profiler.h:128: explicit ProfilerEventsProcessor(ProfileGenerator* generator, On 2013/04/25 16:06:39, Jakob wrote: > ...

7 years, 8 months ago (2013-04-26 07:49:38 UTC) #4

yurys

7 years, 8 months ago (2013-04-26 07:50:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r14446 (presubmit successful).

Expand Messages | Collapse Messages