test/cctest/test-profile-generator.cc - Issue 14471035: Avoid unnecessary indirection when creating CodeEntries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-profile-generator.cc

Issue 14471035: Avoid unnecessary indirection when creating CodeEntries (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fixed nit Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-profile-generator.cc

diff --git a/test/cctest/test-profile-generator.cc b/test/cctest/test-profile-generator.cc

index 56b1788a85132140bfeb0d7bea36479f0f0deb36..85adeca5f468cd145260f1bf7800625e40ba1621 100644

--- a/test/cctest/test-profile-generator.cc

+++ b/test/cctest/test-profile-generator.cc

@@ -611,9 +611,9 @@ TEST(RecordTickSample) {

CpuProfilesCollection profiles;

profiles.StartProfiling("", 1, false);

ProfileGenerator generator(&profiles);

- CodeEntry* entry1 = generator.NewCodeEntry(i::Logger::FUNCTION_TAG, "aaa");

- CodeEntry* entry2 = generator.NewCodeEntry(i::Logger::FUNCTION_TAG, "bbb");

- CodeEntry* entry3 = generator.NewCodeEntry(i::Logger::FUNCTION_TAG, "ccc");

+ CodeEntry* entry1 = profiles.NewCodeEntry(i::Logger::FUNCTION_TAG, "aaa");

+ CodeEntry* entry2 = profiles.NewCodeEntry(i::Logger::FUNCTION_TAG, "bbb");

+ CodeEntry* entry3 = profiles.NewCodeEntry(i::Logger::FUNCTION_TAG, "ccc");

generator.code_map()->AddCode(ToAddress(0x1500), entry1, 0x200);

generator.code_map()->AddCode(ToAddress(0x1700), entry2, 0x100);

generator.code_map()->AddCode(ToAddress(0x1900), entry3, 0x50);

@@ -727,9 +727,9 @@ TEST(SampleIds) {

CpuProfilesCollection profiles;

profiles.StartProfiling("", 1, true);