Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1446543002: Only support jpeg, png, and webp for BRD (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@reeanble
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Only support jpeg, png, and webp for BRD This a safety check to ensure that we don't accidentally ship subset decoders for non-required formats. BUG=skia: Committed: https://skia.googlesource.com/skia/+/73d882e13fc54ff9ecc53a83838c2d900ebf8397

Patch Set 1 #

Total comments: 2

Patch Set 2 : Assert kTopDown or kNone #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M src/android/SkBitmapRegionDecoder.cpp View 1 1 chunk +25 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
msarett
5 years, 1 month ago (2015-11-13 19:07:20 UTC) #2
scroggo
https://codereview.chromium.org/1446543002/diff/1/src/android/SkBitmapRegionDecoder.cpp File src/android/SkBitmapRegionDecoder.cpp (left): https://codereview.chromium.org/1446543002/diff/1/src/android/SkBitmapRegionDecoder.cpp#oldcode39 src/android/SkBitmapRegionDecoder.cpp:39: switch (codec->getScanlineOrder()) { I suppose you took this out ...
5 years, 1 month ago (2015-11-16 14:20:07 UTC) #3
msarett
https://codereview.chromium.org/1446543002/diff/1/src/android/SkBitmapRegionDecoder.cpp File src/android/SkBitmapRegionDecoder.cpp (left): https://codereview.chromium.org/1446543002/diff/1/src/android/SkBitmapRegionDecoder.cpp#oldcode39 src/android/SkBitmapRegionDecoder.cpp:39: switch (codec->getScanlineOrder()) { On 2015/11/16 14:20:06, scroggo wrote: > ...
5 years, 1 month ago (2015-11-16 14:27:51 UTC) #4
scroggo
lgtm
5 years, 1 month ago (2015-11-16 14:32:03 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 1445643002 Patch 1). Please resolve the dependency and ...
5 years, 1 month ago (2015-11-16 20:51:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446543002/20001
5 years, 1 month ago (2015-11-16 21:14:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/4179)
5 years, 1 month ago (2015-11-16 21:14:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446543002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446543002/80001
5 years, 1 month ago (2015-11-16 21:17:31 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-16 21:30:24 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://skia.googlesource.com/skia/+/73d882e13fc54ff9ecc53a83838c2d900ebf8397

Powered by Google App Engine
This is Rietveld 408576698