Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: build/config/features.gni

Issue 1446453004: Adding third_party/openh264 build files for encoding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved BUILD.gn deps to 'both_gn_and_gyp', added corresponding change to gn_migration.gypi Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index d8ddb4743ab76fad43f55935eb525c5ecf8d4fc0..9bf297c6ffa22faea26d6dad20e64701d4686b41 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -54,6 +54,12 @@ declare_args() {
# TODO(GYP) make mac work.
enable_webrtc = !is_ios && !is_mac
+ # Enable this to build OpenH264.
+ # CHECK THE OPENH264 LICENSE BEFORE BUILDING. The default value should be 0,
+ # the open source version of Chromium should not build this by default due to
+ # license and patent reasons.
+ use_openh264 = true
phoglund_chromium 2015/11/16 14:51:41 Same here.
phoglund_chromium 2015/11/16 14:52:21 Acknowledged.
Dirk Pranke 2015/11/17 02:54:19 "The default value should be false", not 0. Also,
Dirk Pranke 2015/11/17 23:49:14 One more comment ... we shouldn't be adding new se
hbos_chromium 2015/11/18 15:55:03 Done. Did the corresponding thing for gyp. + open
+
# Enables the Media Router.
enable_media_router = !is_ios

Powered by Google App Engine
This is Rietveld 408576698