build/common.gypi - Issue 1446453004: Adding third_party/openh264 build files for encoding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1446453004: Adding third_party/openh264 build files for encoding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved BUILD.gn deps to 'both_gn_and_gyp', added corresponding change to gn_migration.gypi Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 9f2f91ad20e14c5ab3406debd21f85bc5eb70d36..a584952235e19bd7376fa6c69878f92aaa0dd85f 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1244,6 +1244,12 @@

'android_app_version_code%': '<(android_app_version_code)',

'enable_webvr%': '<(enable_webvr)',

+ # Enable this to build OpenH264.

+ # CHECK THE OPENH264 LICENSE BEFORE BUILDING. The default value should be 0,

+ # the open source version of Chromium should not build this by default due

+ # to license and patent reasons.

+ 'use_openh264%': 1,

phoglund_chromium 2015/11/16 14:51:41 Only, it's 1. Is this temporary just to run on the

phoglund_chromium 2015/11/16 14:52:21 Oh, right, you wrote that in the CL desc. Never mi

# Turns on compiler optimizations in V8 in Debug build.

'v8_optimized_debug%': 1,

« no previous file with comments | « build/all.gyp ('k') | build/config/features.gni » ('j') | build/config/features.gni » ('J')