Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1446303002: Disable testcase7.bmp on SkImageDecoder and clean up dm_flags (Closed)

Created:
5 years, 1 month ago by msarett
Modified:
5 years, 1 month ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable testcase7.bmp on SkImageDecoder and clean up dm_flags testcase7.bmp leaves uninitialized memory. Also remove "subset" dm flags. The "subset" test no longer exists. BUG=skia: Committed: https://skia.googlesource.com/skia/+/44509faecef54ba57e56d60dfc0b91cfefba2d5c

Patch Set 1 #

Patch Set 2 : Adding changes to dm_flags.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -363 lines) Patch
M tools/dm_flags.json View 1 21 chunks +20 lines, -352 lines 0 comments Download
M tools/dm_flags.py View 3 chunks +1 line, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
msarett
5 years, 1 month ago (2015-11-16 18:01:50 UTC) #2
scroggo
1gtm, but first you need to update dm_flags.json (I think by running dm_flags.py?)
5 years, 1 month ago (2015-11-16 20:34:53 UTC) #3
msarett
Thanks, adding the changes to the json.
5 years, 1 month ago (2015-11-16 20:39:36 UTC) #4
scroggo
lgtm
5 years, 1 month ago (2015-11-17 15:23:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1446303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1446303002/20001
5 years, 1 month ago (2015-11-17 15:24:27 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 15:36:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/44509faecef54ba57e56d60dfc0b91cfefba2d5c

Powered by Google App Engine
This is Rietveld 408576698