Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 144613003: Remove use of CoreAudioUtil::IsSupported() from AudioManager startup. (Closed)

Created:
6 years, 11 months ago by DaleCurtis
Modified:
6 years, 11 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove use of CoreAudioUtil::IsSupported() from AudioManager startup. The method attempts to load the audioses.dll and create an MMDeviceEnumerator object. Such actions should be avoided in the constructor since it's blocking the UI loop. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246527

Patch Set 1 : Fix. #

Patch Set 2 : Fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M content/browser/renderer_host/media/audio_input_device_manager_unittest.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M media/audio/audio_manager_unittest.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M media/audio/win/audio_manager_win.h View 1 chunk +4 lines, -3 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 2 chunks +18 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
DaleCurtis
Found while discussing potential sources of UI thread slowness.
6 years, 11 months ago (2014-01-22 02:47:50 UTC) #1
henrika (OOO until Aug 14)
Looks like a nice cleanup for many reasons. May I ask for some more details ...
6 years, 11 months ago (2014-01-22 09:24:27 UTC) #2
DaleCurtis
No actual issues that I know of, it's more a theoretical change to avoid as ...
6 years, 11 months ago (2014-01-22 18:32:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/144613003/30001
6 years, 11 months ago (2014-01-22 18:33:29 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=249940
6 years, 11 months ago (2014-01-22 19:41:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/144613003/310001
6 years, 11 months ago (2014-01-22 23:54:14 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=193637
6 years, 11 months ago (2014-01-23 01:49:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/144613003/310001
6 years, 11 months ago (2014-01-23 01:52:31 UTC) #8
commit-bot: I haz the power
Change committed as 246527
6 years, 11 months ago (2014-01-23 04:35:57 UTC) #9
henrika (OOO until Aug 14)
6 years, 11 months ago (2014-01-23 08:37:18 UTC) #10
Message was sent while issue was closed.
Sounds great. I like it.

Powered by Google App Engine
This is Rietveld 408576698