Plumbed in discard_framebuffer extension

First step.

Compiled and run on: Win7, MacPro, Linux and Android.

[robertphillips, 2013-04-29 14:35:08]

Not used yet but enough changes that I don't want the bits to rot.

[bsalomon, 2013-04-29 14:42:15]

https://codereview.chromium.org/14461006/diff/16001/src/gpu/gl/GrGLInterface.cpp
File src/gpu/gl/GrGLInterface.cpp (right):

https://codereview.chromium.org/14461006/diff/16001/src/gpu/gl/GrGLInterface....
src/gpu/gl/GrGLInterface.cpp:298: if
(extensions.has("GL_EXT_discard_framebuffer")) {
Might be worth checking if Chrome passes along this extension. If not, we need
to get it. If so we have to skip this check until Chrome gives us the ptr.

https://codereview.chromium.org/14461006/diff/16001/src/gpu/gl/mac/GrGLCreate...
File src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp (right):

https://codereview.chromium.org/14461006/diff/16001/src/gpu/gl/mac/GrGLCreate...
src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp:152: if
(extensions.has("GL_EXT_discard_framebuffer")) {
Does this extension exist on desktop? If not we can just leave all the desktop
GrGLInterface setup functions alone.

[robertphillips, 2013-04-29 15:25:38]

This patch removes the desktop-side handling for the discard extension and
disables the validation check until Chrome can be updated.

https://codereview.chromium.org/14461006/diff/16001/src/gpu/gl/GrGLInterface.cpp
File src/gpu/gl/GrGLInterface.cpp (right):

https://codereview.chromium.org/14461006/diff/16001/src/gpu/gl/GrGLInterface....
src/gpu/gl/GrGLInterface.cpp:298: if
(extensions.has("GL_EXT_discard_framebuffer")) {
On 2013/04/29 14:42:15, bsalomon wrote:
> Might be worth checking if Chrome passes along this extension. If not, we need
> to get it. If so we have to skip this check until Chrome gives us the ptr.

Done.

https://codereview.chromium.org/14461006/diff/16001/src/gpu/gl/mac/GrGLCreate...
File src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp (right):

https://codereview.chromium.org/14461006/diff/16001/src/gpu/gl/mac/GrGLCreate...
src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp:152: if
(extensions.has("GL_EXT_discard_framebuffer")) {
As far as I can tell (from looking at the spec and registry) it does not.

[bsalomon, 2013-04-29 16:40:58]

lgtm

[robertphillips, 2013-04-29 16:50:38]

committed as r8906